Bug 381231 - password dialog size
Summary: password dialog size
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kwidgetsaddons
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.35.0
Platform: Compiled Sources All
: NOR minor
Target Milestone: ---
Assignee: Christoph Feck
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-15 13:38 UTC by RJVB
Modified: 2017-11-08 13:59 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
example kwalletd5 password dialog showing lots of needless space waste. (24.66 KB, image/png)
2017-06-15 13:38 UTC, RJVB
Details
"packed" dialog (23.37 KB, image/png)
2017-06-15 14:45 UTC, RJVB
Details
patch (2.87 KB, patch)
2017-06-15 14:51 UTC, RJVB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description RJVB 2017-06-15 13:38:24 UTC
Created attachment 106112 [details]
example kwalletd5 password dialog showing lots of needless space waste.

Now that kwalletd5 replaces kwalletd4 even on "FrankenStux" rigs like mine (Plasma4 desktop with KF5 stuff installed into /opt/local) I'm seeing only the former's wallet unlock dialogs and have no longer any interest in being able to know which daemon is asking.

Something I've been very mildly annoyed by thus became more "urgent": why is there so much useless space in the kwalletd5 password request dialogs?

I'd post a screenshort for comparison, but will first have to find a bootable backup that still uses kwalletd4...
Comment 1 RJVB 2017-06-15 13:54:25 UTC
moved to KWidgetsAddons
Comment 2 RJVB 2017-06-15 14:44:34 UTC
Has anything changed in the way Qt (re)sizes dialog windows as a function of the enabled/disabled items? After setting the layout size constraint to SetFixedSize in the .ui file (plus a few other tweaks that probably don't matter) I'm getting something that looks a lot less clumsy; see the 2nd screenshot.
Comment 3 RJVB 2017-06-15 14:45:54 UTC
Created attachment 106114 [details]
"packed" dialog
Comment 4 RJVB 2017-06-15 14:51:23 UTC
Created attachment 106115 [details]
patch

The patch for v5.35.0 which gives me the packed password dialog. Certain changes are probably just due to saving the file in a different (newer - v5.8.0?) Qt Designer version.
Comment 5 Nate Graham 2017-10-23 15:18:34 UTC
RJVB, can you submit this patch (minus unnecessary changes) on https://phabricator.kde.org/? Patches tend to get lost in bug reports.
Comment 6 RJVB 2017-10-23 16:17:26 UTC
https://phabricator.kde.org/D8437
Comment 7 RJVB 2017-10-27 16:55:16 UTC
Git commit 9afc2c3768e0189583ae15e34c93884f2c511513 by R.J.V. Bertin.
Committed on 27/10/2017 at 16:55.
Pushed by rjvbb into branch 'master'.

more compact password dialog

This removes the extra padding that got added to the password dialog
somewhere during the KDE4 -> KF5 transition.

Differential Revision: https://phabricator.kde.org/D8437

M  +10   -1    src/kpassworddialog.ui

https://commits.kde.org/kwidgetsaddons/9afc2c3768e0189583ae15e34c93884f2c511513