Bug 381175 - Add filename preview to Preferences window
Summary: Add filename preview to Preferences window
Status: RESOLVED FIXED
Alias: None
Product: Spectacle
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR wishlist
Target Milestone: ---
Assignee: Boudhayan Gupta
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2017-06-14 02:02 UTC by KDE Neon user
Modified: 2019-03-21 23:15 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 19.08.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description KDE Neon user 2017-06-14 02:02:56 UTC
It'd be nice if the Preferences window showed an example of your filenames will look like as you edit the strings, like music players do when you edit the title bar/system tray format.
Comment 1 null 2018-02-21 16:54:01 UTC
This is done quite nicely in Gwenview's importer (type "gwenview_importer .", click on "Settings"). Perhaps it could be reused from there?

Note: Replicating Gwenview's click-to-input placeholders in Spectacle is tracked in Bug 390856.
Comment 2 Nate Graham 2019-03-18 09:13:37 UTC
Git commit 37448f5c48ee0d8799c3dda6dbe5fc1e3fe41147 by Nate Graham, on behalf of David Redondo.
Committed on 18/03/2019 at 09:13.
Pushed by ngraham into branch 'master'.

Show preview of the filename in the save settings

Summary:
Shows the a preview of the configured filename template on the save settings page. I'm not sure about the placement of the label but the functionality should be there. This also again includes a small refactor to access the placeholder replacement from outside of the ExportManager.

Test Plan: {F6697579}

Reviewers: #spectacle, #vdg, ngraham

Reviewed By: #spectacle, #vdg, ngraham

Subscribers: meven, ngraham, broulik

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D19775

M  +6    -1    src/ExportManager.cpp
M  +1    -0    src/ExportManager.h
M  +26   -6    src/Gui/SettingsDialog/SaveOptionsPage.cpp
M  +4    -0    src/Gui/SettingsDialog/SaveOptionsPage.h

https://commits.kde.org/spectacle/37448f5c48ee0d8799c3dda6dbe5fc1e3fe41147
Comment 3 Nate Graham 2019-03-21 23:15:37 UTC
Git commit 4602c0efc01f7728c196d7a5c98c30fe23ae3009 by Nate Graham, on behalf of David Redondo.
Committed on 21/03/2019 at 23:15.
Pushed by ngraham into branch 'Applications/19.04'.

Show preview of the filename in the save settings

Summary:
Shows the a preview of the configured filename template on the save settings page. I'm not sure about the placement of the label but the functionality should be there. This also again includes a small refactor to access the placeholder replacement from outside of the ExportManager.

Test Plan: {F6697579}

Reviewers: #spectacle, #vdg, ngraham

Reviewed By: #spectacle, #vdg, ngraham

Subscribers: meven, ngraham, broulik

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D19775

M  +6    -1    src/ExportManager.cpp
M  +1    -0    src/ExportManager.h
M  +26   -6    src/Gui/SettingsDialog/SaveOptionsPage.cpp
M  +4    -0    src/Gui/SettingsDialog/SaveOptionsPage.h

https://commits.kde.org/spectacle/4602c0efc01f7728c196d7a5c98c30fe23ae3009