Bug 381170 - Show on Updates page which updates are security-related
Summary: Show on Updates page which updates are security-related
Status: CONFIRMED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-13 21:22 UTC by andreas
Modified: 2022-09-25 13:25 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description andreas 2017-06-13 21:22:10 UTC
the plasmoid show different icons if there are update (blue point) or security updates (red point) available.

discover didn't show which is a security update and  which not. as the notification widget had this information it would be nice to give the user in discover updater also this information.
Comment 1 Aleix Pol 2017-06-19 16:28:11 UTC
Are you sure this is the case? Because it should be showing the right icon (see QString DiscoverNotifier::iconName() const)

What makes you think it's not done properly?
Comment 2 andreas 2017-06-19 20:41:53 UTC
the plasmoid did show the right icon but I miss the security information in the discover updater. which packages need an security issues update?
Comment 3 Aleix Pol 2017-06-19 23:03:57 UTC
How does that make a difference? Will you choose not to update depending on which packages need update?
Comment 4 Christoph Feck 2017-06-26 13:20:20 UTC
This is especially interesting for users of rolling releases. Sometimes I delay applying updates for several months (instead of updating nearly daily) to minize wear-out SSD drive, but should apply security updates as soon as they are available.
Comment 5 Aleix Pol 2017-06-28 18:07:06 UTC
@Christoph, so the plasmoid does show a different icon, andreas's complaint is that once you open Discover on update mode, you don't get to see which one it is.
Comment 6 Aleix Pol 2018-01-08 17:41:19 UTC
Git commit 0c1c5a16a7d6a52d6026b84ef094a2f2f258d2ab by Aleix Pol.
Committed on 08/01/2018 at 17:37.
Pushed by apol into branch 'master'.

Use update-high as the updates page icon if there's security updates

M  +1    -1    discover/qml/DiscoverWindow.qml
M  +14   -3    libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp
M  +2    -0    libdiscover/backends/PackageKitBackend/PackageKitBackend.h
M  +6    -0    libdiscover/resources/AbstractResourcesBackend.h
M  +11   -0    libdiscover/resources/ResourcesModel.cpp
M  +2    -0    libdiscover/resources/ResourcesModel.h

https://commits.kde.org/discover/0c1c5a16a7d6a52d6026b84ef094a2f2f258d2ab
Comment 7 Shai 2021-10-07 08:00:14 UTC
This is marked as fixed but I still can't tell which are the security updates
Comment 8 Nate Graham 2021-10-07 14:20:33 UTC
Indeed.

However I think what Aleix was saying is that this isn't something we want to do. The System Tray Notifier's only UI is a tooltip; we can't put information on every package in there; it would get absurdly large.
Comment 9 Shai 2021-10-09 12:15:13 UTC
Indeed.

But I think the expectation -- certainly mine, but also what I read in the Description -- is to show which updates are security updates in Discover, not in the notifier.

Instead of marking each update accordingly, IIUC Aleix changed the whole page icon for updates to match that in the notifier. That does not add information.
Comment 10 Nate Graham 2021-10-11 15:37:34 UTC
Ah, ok.