Bug 381158 - Changes lost if not applied before editing another connection
Summary: Changes lost if not applied before editing another connection
Status: RESOLVED FIXED
Alias: None
Product: plasma-nm
Classification: Plasma
Component: kcm (show other bugs)
Version: 5.9.5
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Jan Grulich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-13 15:01 UTC by KDE Neon user
Modified: 2017-10-31 07:26 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description KDE Neon user 2017-06-13 15:01:13 UTC
1 - Open your network settings
2 - Go to the IPv4 or IPv6 tab of your wired connection, and change some settings
3 - Click on the entry for your wireless connection

Result:
The changes made to the wired connection are reversed, because you didn't click on "Apply".

Expected result: the changes should be kept, so that multiple connections can be edited at once, or at least it should warm the user to apply or cancel before editing another connection.
Comment 1 Jan Grulich 2017-06-14 05:37:57 UTC

*** This bug has been marked as a duplicate of bug 380299 ***
Comment 2 Jan Grulich 2017-06-14 05:38:23 UTC
Sorry, ignore the comment about duplicate.
Comment 3 Jan Grulich 2017-10-03 11:02:30 UTC
Git commit 003ce1d5fe3c41f7d59a32e70285d0c2538d2c3b by Jan Grulich.
Committed on 03/10/2017 at 11:02.
Pushed by grulich into branch 'master'.

Ask to save modified connection when selecting another one

M  +43   -16   kcm/kcm.cpp
M  +3    -1    kcm/kcm.h
M  +2    -3    kcm/qml/ConnectionItem.qml
M  +16   -4    kcm/qml/main.qml

https://commits.kde.org/plasma-nm/003ce1d5fe3c41f7d59a32e70285d0c2538d2c3b
Comment 4 Patrick Silva 2017-10-30 16:38:40 UTC
Which release includes this fix?
It`s not fixed on neon user edition, plasma 5.11.2.
Comment 5 Jan Grulich 2017-10-31 07:26:58 UTC
This is fixed in master, it cannot be backported to Plasma 5.11 as it introduces a new string.