In 17.04.0, transcode support has been disabled (bug#360170). This means that it's currently not possible at all to rip Video DVDs. And even worse, k3b tells the user that transcode couldn't be found even if it is installed. openSUSE's transcode seems to work fine though AFAICT, so I would like to ask you to reconsider that decision and enable transcode support again. Why should people not be able to use it (and DVD ripping at all), if their distribution provides a working transcode? Of course ideally support for other tools should be implemented, maybe ffmpeg could be used? In any case, if transcode is not supported, k3b should not ask the user to install it. And if Video DVD ripping is not working at all (as it is the case now), the menu option should probably be removed completely.
*** This bug has been marked as a duplicate of bug 360170 ***
Sorry, I know you disabled transcode because of bug#360170. But this is no way a duplicate. And the current situation is really bad. Let me restate the current problems: - Ripping VideoDVDs does not work at all - If you try to do it, k3b tells you to install transcode (which is not supported, so installing it doesn't change anything.) OTOH, transcode works fine in openSUSE. Even if it is unmaintained upstream, distributions/packagers do still support it and keep it working (with newer ffmpeg e.g.). So re-enabling that would be the easiest/quickest way to fix VideoDVD ripping IMHO. Maybe you could display a warning dialog that transcode is not maintained upstream and there may be problems... If you don't want to do that, you should at least change the current error dialog.
Hi Wolfgang, Thanks for your kind response! > Sorry, I know you disabled transcode because of bug#360170. > But this is no way a duplicate. Sorry for that! > > And the current situation is really bad. Let me restate the current problems: > - Ripping VideoDVDs does not work at all > - If you try to do it, k3b tells you to install transcode (which is not > supported, so installing it doesn't change anything.) Yes! very bad! so someone want to disable it https://git.reviewboard.kde.org/r/130011/ > > OTOH, transcode works fine in openSUSE. Even if it is unmaintained upstream, > distributions/packagers do still support it and keep it working (with newer > ffmpeg e.g.). I investigated transcode http://www.leetcode.cn/2016/08/k3b.html and I quoted it here: It is not encrypted issue at all! libdvdcss is able to access and unscramb DVDs encrypted with the Content Scramble System (CSS), but transcode failed to rip videodvd (see screenshot https://pbs.twimg.com/media/CrJ54YmVYAEDLL9.jpg) using mplayer to test the output *.avi, and debug info goes here. There is a looping failure for libdvdread's CHECK_VALUE(dsi->dsi_gi.zero1 == 0), but it doesn't matter, using mplayer to rip videodvd mplayer -dumpstream dvd:////dev/sr0 -nocache -dumpfile test.mpg also print out such stuff! But pay more attention to ffmpeg libavcodec's warning: [mpeg4 @ 0x55a0daf96a40] AVFrame.format is not set [mpeg4 @ 0x55a0daf96a40] AVFrame.width or height is not set I reported the issue to UPSTREAM ArchLinux packager choosing transcode-1.1.7's tarball, but transcoding.org domain relocating to https://bitbucket.org/achurch_/transcode/wiki/Home, so I have no idea what happened - yet another transcode v1.2.0-d302c3a215bb, and failed to build for ffmpeg v3.1.3, then I migrated it, NOT be merged again! transcode-1.2 (binary name) still failed to rip videodvd, same story as the screenshot. > So re-enabling that would be the easiest/quickest way to fix VideoDVD > ripping IMHO. > Maybe you could display a warning dialog that transcode is not maintained > upstream and there may be problems... > > If you don't want to do that, you should at least change the current error > dialog. I argue that ffmpeg is a better alternative choice for taking place of transcode, thoughts? Regards, Leslie Zhai
Hi Wolfgang, > Sorry, I know you disabled transcode because of bug#360170. > But this is no way a duplicate. > Sorry for my impatient because my father is homeless https://twitter.com/xiangzhai/status/873565065605029895 But I need to work harder to buy apartment for him :) Regards, Leslie Zhai
Wolfgang Bauer, You might consider what I say in bug#379166, which addresses this issue. It almost seems like disabling DVD ripping was inadvertent, the way it come about. There is also a patch to fix it at https://bugs.launchpad.net/ubuntu/+source/k3b/+bug/1686089
Hi Jim, If transcode was able to work for Ubuntu, but I doubt about it https://bitbucket.org/france/transcode-tcforge/issues/8/rip-dvd-avframeformat-is-not-set I will revert the deprecated, unfortunately transcode was not be maintained any more https://bitbucket.org/achurch_/transcode/pull-requests/1/migrate-to-ffmpeg-313/diff and LibAV developers often change API, so even enable transcode by your patch, it still failed to work in the new system, people could not always use old buggy system, correct? Better solution is ffmepg command, but not LibAV, developer don't want to migrate all the time https://github.com/isoft-linux/libKeyFrame/blob/master/libKeyFrame.c#L295 it is helpless for improving development skill, but waste our time actually! Welcome ffmepg patch, just like my cdrskin support https://bugs.kde.org/show_bug.cgi?id=137436 Migrated to libburnia already and code review by Thomas Schmitt, so argue is cheap show me the patch ;-) thanks! Regards, Leslie Zhai
Actually, transcode worked fine for me after I patched it as per this: https://bugs.launchpad.net/ubuntu/+source/transcode/+bug/1099201 Doing so allowed me to successfully rip my Firefly and Serenity DVDs. Because of this, I think it would better serve the users to keep transcode until a replacement is implemented. If you wish, you could emit a warning that the external tool may crash, but to disable it because it's buggy without guiding the user to a suitable replacement is more a reduction in functionality... especially when the message pops up to ensure that it is installed. You could adjust that message to say "DVD ripping is temporarily disabled... use XYZ, instead".
Hi Jim, Thanks for your patch! > Actually, transcode worked fine for me after I patched it as per this: > > https://bugs.launchpad.net/ubuntu/+source/transcode/+bug/1099201 I will test it in my Fedora 24, I am using my phone to reply... > > Doing so allowed me to successfully rip my Firefly and Serenity DVDs. Cool! then we can introduce the patch to other Linux distributions :) > > Because of this, I think it would better serve the users to keep transcode > until a replacement is implemented. If you wish, you could emit a warning > that the external tool may crash, but to disable it because it's buggy > without guiding the user to a suitable replacement is more a reduction in > functionality... especially when the message pops up to ensure that it is > installed. > > You could adjust that message to say "DVD ripping is temporarily disabled... > use XYZ, instead". Doesn't need the warning any more, my sincere thank goes to you. Regards, Leslie Zhai
(In reply to Leslie Zhai from comment #8) > Thanks for your patch! Actually it's not my patch, I just found it by searching for the error message I received. If it still fails for you after that patch, let me know how to reproduce the failure and I'll see if there is a way to fix it.
Ok! > (In reply to Leslie Zhai from comment #8) > > Thanks for your patch! > > Actually it's not my patch, I just found it by searching for the error > message I received. > > If it still fails for you after that patch, let me know how to reproduce the > failure and I'll see if there is a way to fix it.
FWIW, these are the patches in openSUSE's transcode package: https://pmbs.links2linux.de/package/show/Multimedia/transcode As I wrote, ripping Video DVDs works fine here after patching k3b to use transcode again, at least those that I tried, with the default settings (MPEG4). I fully agree that implementing support for ffmpeg is probably the best way to go (I even suggested that myself... ;-) ), but I also think that support for transcode shouldn't be dropped before that is implemented. Currently it is broken for everybody, even those who do have a working transcode... But if I read the previous comments correctly, you are considering to re-enable it now anyway. Thank you in advance.
Yes! Ubuntu and openSUSE is able to work :) then I will test the patch for ArchLinux and Fedora. > FWIW, these are the patches in openSUSE's transcode package: > https://pmbs.links2linux.de/package/show/Multimedia/transcode > > As I wrote, ripping Video DVDs works fine here after patching k3b to use > transcode again, at least those that I tried, with the default settings > (MPEG4). > > I fully agree that implementing support for ffmpeg is probably the best way > to go (I even suggested that myself... ;-) ), but I also think that support > for transcode shouldn't be dropped before that is implemented. Currently it > is broken for everybody, even those who do have a working transcode... > > But if I read the previous comments correctly, you are considering to > re-enable it now anyway. > Thank you in advance.
(In reply to Jim from comment #5) > Wolfgang Bauer, > > You might consider what I say in bug#379166, which addresses this issue. Yes, I patched k3b myself (uncomment the code in K3b::addTranscodePrograms()) to test it before I filed this bug report... ;-)
Git commit c8ed0188800a5b8e010a6f25fc9e7d8af363892a by Leslie Zhai. Committed on 14/06/2017 at 02:53. Pushed by lesliezhai into branch 'master'. Keep transcode until a replacement is implemented. M +15 -0 ChangeLog M +2 -1 libk3b/core/k3bdefaultexternalprograms.cpp https://commits.kde.org/k3b/c8ed0188800a5b8e010a6f25fc9e7d8af363892a