Bug 381051 - Breeze/Breeze Dark icons for text/x-python and application/x-python-bytecode shouldn't be identical
Summary: Breeze/Breeze Dark icons for text/x-python and application/x-python-bytecode ...
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: 5.10.0
Platform: Neon Linux
: NOR wishlist
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-10 03:20 UTC by stevemcqueen
Modified: 2018-12-29 18:23 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.54


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description stevemcqueen 2017-06-10 03:20:48 UTC
For both the Breeze and Breeze Dark icon sets, the icons associated to both text/x-python and application/x-python-bytecode are exactly the same. I believe they are actually symlinked to each other.

When viewing a folder full of python files, this makes it quite difficult to distinguish the code files (foo.py) that you actually want to open and edit from the bytecode files (foo.pyc) that you rarely, if ever, want to open.

Consider the distinction that the Oxygen icon set provides between the two in the following screenshot:
http://i.imgur.com/Mpvrq2W.png

verses what it looks like in Breeze:
http://i.imgur.com/zbEo4d2.png

and in Breeze Dark:
http://i.imgur.com/HTABc4Z.png


Could Breeze/Breeze Dark split the two up, and provide some contrast between the two filetypes? Perhaps darken and/or grey out the icon? Or switch to another icon used for other compiled file types?
Comment 1 Nate Graham 2018-12-29 18:23:28 UTC
Git commit 6baded2e1df4e1ca08a670ef73cd1da02e726f12 by Nate Graham, on behalf of Rafael Brandmaier.
Committed on 29/12/2018 at 18:23.
Pushed by ngraham into branch 'master'.

Add a proper python-bytecode icon, use consistent color in python icons

Summary:

FIXED-IN: 5.54

Add a separate, more recognizable icon for `application-x-python-bytecode`. Use a consistent, orange color for the `32px` and `64px` designs of `application-x-python-bytecode` and `text-x-python`.

The font used at all sizes except `64px` is made of custom shapes to be as pixel-perfect as possible.

Test Plan:
The new `application-x-python-bytecode` icons:
{F6514919}

Consistent style for `32px` and `64px` `application-x-python-bytecode` and `text-x-python`:
{F6489825}

Reviewers: #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17692

A  +1    -0    icons-dark/mimetypes/16/application-x-python-bytecode.svg
M  +1    -3    icons-dark/mimetypes/16/text-x-python.svg
A  +1    -0    icons-dark/mimetypes/22/application-x-python-bytecode.svg
M  +1    -85   icons-dark/mimetypes/22/text-x-python.svg
A  +1    -0    icons-dark/mimetypes/32/application-x-python-bytecode.svg
M  +1    -28   icons-dark/mimetypes/32/text-x-python.svg
A  +1    -0    icons-dark/mimetypes/64/application-x-python-bytecode.svg
M  +1    -26   icons-dark/mimetypes/64/text-x-python.svg
A  +1    -0    icons/mimetypes/16/application-x-python-bytecode.svg
M  +1    -3    icons/mimetypes/16/text-x-python.svg
A  +1    -0    icons/mimetypes/22/application-x-python-bytecode.svg
M  +1    -85   icons/mimetypes/22/text-x-python.svg
A  +1    -0    icons/mimetypes/32/application-x-python-bytecode.svg
M  +1    -135  icons/mimetypes/32/text-x-python.svg
A  +1    -0    icons/mimetypes/64/application-x-python-bytecode.svg
M  +1    -216  icons/mimetypes/64/text-x-python.svg

https://commits.kde.org/breeze-icons/6baded2e1df4e1ca08a670ef73cd1da02e726f12