Bug 380848 - Remove any mention of currency or currency conversion from reports if the current KMM file uses only a single currency.
Summary: Remove any mention of currency or currency conversion from reports if the cur...
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: 4.8.0
Platform: Other FreeBSD
: NOR wishlist
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-05 01:45 UTC by Henry Miller
Modified: 2017-06-20 19:25 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Miller 2017-06-05 01:45:18 UTC
I'm using KMyMoney for a local organisation, and I need to present monthly reports to the rest of the committee.  We only deal in US dollars and as a local focused origination there is no reason to expect to ever get other currency (there may even be legal implications to foreign transactions).  As such the line on reports indicating "all currencies converted to US dollars" is at best not required and may even be misleading.

I realise that this notice is important when someone has transactions/accounts in multiple currencies, but I suspect that isn't the most common use case. In any case I don't think it should br brought out when not required.
Comment 1 Thomas Baumgart 2017-06-05 08:52:16 UTC
Reports have an option called "Convert values to base currency" which is usually checked. Turn it off and the message will be exchanged with "All values shown in USD unless otherwise stated" (or similar). See https://docs.kde.org/stable4/en/extragear-office/kmymoney/details.reports.config.html for details.
Comment 2 Henry Miller 2017-06-05 11:59:52 UTC
I'm aware of that checkbox, it just changes the text to "All values shown in US dollars unless otherwise noted".  Since I only deal in US dollars I do not want this notice at all. 

I agree this notice is important (even critical) when someone deals with multiple currencies. However when someone does not it isn't helpful.
Comment 3 Jack 2017-06-05 15:38:06 UTC
Perhaps reword the wishlist request as "Remove any mention of currency or currency conversion from reports if the current KMM file uses only a single currency."
Comment 4 wojnilowicz 2017-06-20 19:25:56 UTC
Git commit 6351a2324d3218044ce9366d9631b73b7fdd6576 by Łukasz Wojniłowicz.
Committed on 20/06/2017 at 19:21.
Pushed by wojnilowicz into branch 'master'.

Don't display unnecessary currency information
FIXED-IN:5.0

Differential Revision: https://phabricator.kde.org/D6167

Signed-off-by: Łukasz Wojniłowicz <lukasz.wojnilowicz@gmail.com>

M  +4    -30   kmymoney/reports/listtable.cpp
M  +1    -2    kmymoney/reports/listtable.h
M  +142  -169  kmymoney/reports/pivottable.cpp
M  +3    -5    kmymoney/reports/pivottable.h
M  +18   -0    kmymoney/reports/querytable.cpp
M  +49   -26   kmymoney/reports/reporttable.cpp
M  +10   -10   kmymoney/reports/reporttable.h
M  +2    -1    kmymoney/reports/tests/pivottable-test.cpp
M  +4    -4    kmymoney/reports/tests/querytable-test.cpp
M  +2    -2    kmymoney/reports/tests/reportstestcommon.cpp
M  +5    -8    kmymoney/views/kreportsview.cpp

https://commits.kde.org/kmymoney/6351a2324d3218044ce9366d9631b73b7fdd6576