Bug 380421 - In some cases the vertical "Popup panel" has a very high minimum width (caused by Viewer).
Summary: In some cases the vertical "Popup panel" has a very high minimum width (cause...
Status: RESOLVED FIXED
Alias: None
Product: krusader
Classification: Applications
Component: general (show other bugs)
Version: Git
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krusader Bugs Distribution List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-01 10:55 UTC by Toni Asensi Esteve
Modified: 2018-05-06 00:15 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
File to be viewed in the popup panel, the name is "plasmashellbookmarkrunnerfirefoxdbfile.sqlite-shm" (32.00 KB, application/octet-stream)
2017-06-01 10:55 UTC, Toni Asensi Esteve
Details
Two popup panels that can't be resized so that they use less than (for example) 77% (203.30 KB, image/png)
2017-06-01 10:57 UTC, Toni Asensi Esteve
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toni Asensi Esteve 2017-06-01 10:55:52 UTC
Created attachment 105817 [details]
File to be viewed in the popup panel, the name is "plasmashellbookmarkrunnerfirefoxdbfile.sqlite-shm"

Using Kubuntu 17.04 and Krusader, if I place the cursor on a file like the  "plasmashellbookmarkrunnerfirefoxdbfile.sqlite-shm" that is attached to this report), then I press Alt+Down, on the new "Popup panel" I click the "View panel" button, then I see a warning like
    The file [NAME_OF_THE_FILE] was opened with UTF-8 encoding but contained invalid characters.
    It is set to read-only mode, as saving might destroy its content.
    Either reopen the file with the correct encoding chosen or enable the read-write mode again in the tools menu to be able to edit it.

then I press on the "Close" button of the warning. In that moment the vertical "Popup panel" can't be resized so that it uses less than (for example) 77%, even if the cursor is placed on another file, or if Krusader is closed and reopened.

I attach a screenshot.

Thanks for Krusader!
Comment 1 Toni Asensi Esteve 2017-06-01 10:57:10 UTC
Created attachment 105818 [details]
Two popup panels that can't be resized so that they use less than (for example) 77%
Comment 2 Alex Bikadorov 2017-06-01 20:38:34 UTC
I notices this, too. Open the file with Kate and you'll see the same error message and Kate's window has also a width limitation. But it can be made a little bit smaller.

Widget used here (by Krusader and Kate) is KTextEditor::View.

Did some testing. Can you confirm?:
 * the width limit is absolute and not a relative size
 * the error popup is not the problem. Close it and you still can't make the widget smaller
 * the bottom line (with "Line 1, Column 1...") is preventing a smaller size, if there is no error message.
Comment 3 Alex Bikadorov 2017-06-01 20:46:42 UTC
Git commit 9733d20bd34da3bca15248b46466adaee9de2dcf by Alexander Bikadorov.
Committed on 01/06/2017 at 20:45.
Pushed by abikadorov into branch 'master'.

Panel: Prevent Viewer in PanelPopup to limit the minimum PanelPopup width

New "limit" are the part buttons.

FIXED: [ 380421 ] In some cases the vertical "Popup panel" has a very high minimum width (caused by Viewer).

M  +4    -2    krusader/Panel/panelpopup.cpp

https://commits.kde.org/krusader/9733d20bd34da3bca15248b46466adaee9de2dcf
Comment 4 Alex Bikadorov 2017-06-01 20:47:42 UTC
Anyway, fix was easy:)