Bug 380414 - Plasma pa breaks automatic device selection
Summary: Plasma pa breaks automatic device selection
Status: RESOLVED FIXED
Alias: None
Product: plasma-pa
Classification: Unmaintained
Component: general (other bugs)
Version First Reported In: 5.10.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
: 381091 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-06-01 07:25 UTC by Weng Xuetian
Modified: 2017-06-11 07:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.10.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Weng Xuetian 2017-06-01 07:25:59 UTC
I'm using pulseaudio 10.0. Right now, with plasma-pa 5.10
- if "switch all stream on new device" is NOT checked (i configure my bluetooth headset as the first on in phonon's kcm).
  If i don't open plasma-pa's kcm, everything seems to be fine. As soon as I open plasma-pa's kcm, all stream will be switched to "builtin-audio".

- if "switch all stream on new device" is checked
  if a stream is already playing on built-in audio, when I connect to bluetooth headset, it will not switch to it. But as soon as I open plasma-pa's kcm, stream will be switch to bluetooth headset.

So now, I can't reliable to switch to my bluetooth headset when connect to it.

Also I do not expect that "opening plasma-pa's kcm" should trigger anything that changes the default device.
Comment 1 David Rosca 2017-06-01 07:41:46 UTC
https://phabricator.kde.org/D6055
Comment 2 David Rosca 2017-06-01 07:47:47 UTC
Git commit 2509b6bbf507818ced15b219a693de07b11d5285 by David Rosca.
Committed on 01/06/2017 at 07:46.
Pushed by drosca into branch 'Plasma/5.10'.

Don't call setDefaultSink/Source when already default

Checked state changes are not correctly handled in default device
QtQuickControls checkbox in KCM (changes are applied also for non-user
initiated, eg. on component complete).
This triggers setting the default device when opening KCM which moves all
streams to that device, and it breaks any previous manual configuration
(moving streams to different devices).

Make sure we call setDefaultSink/Source only when the default device
is actually different.
FIXED-IN: 5.10.1

Differential Revision: https://phabricator.kde.org/D6055

M  +1    -1    src/sink.cpp
M  +1    -1    src/source.cpp

https://commits.kde.org/plasma-pa/2509b6bbf507818ced15b219a693de07b11d5285
Comment 3 David Rosca 2017-06-11 07:40:40 UTC
*** Bug 381091 has been marked as a duplicate of this bug. ***