Bug 380358 - ICC Profiles not detected
Summary: ICC Profiles not detected
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-RawImport-Native (show other bugs)
Version: 5.5.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-30 15:19 UTC by Sebastian
Modified: 2022-01-26 04:23 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.6.0


Attachments
Nautilus showing ICC profiles next to DigiKam file browser not showing them. (287.97 KB, image/png)
2017-05-30 15:19 UTC, Sebastian
Details
digiKam 5.6.0 pre-release file dialog (272.98 KB, image/png)
2017-05-31 21:16 UTC, Sebastian
Details
appmenu-qt & appmenu-qt5 installed (11.58 KB, image/png)
2017-05-31 21:17 UTC, Sebastian
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian 2017-05-30 15:19:24 UTC
Created attachment 105782 [details]
Nautilus showing ICC profiles next to DigiKam file browser not showing them.

Hi,

I've recently switched from Mac and I'm desperately trying to get back into my photo workflow. However, my images look really off, I've tried to select my camera's profile as the input profile, but the results are really washed out for some reason.

When I try to apply the profile via the Color Management tab of the RAW Import Tool, ICC files are not detected/listed via the Browse dialog window. In other words, when I navigate to any directory with ICC profiles, none get listed, thus I can't use them. What am I missing?

Thanks!
Comment 1 caulier.gilles 2017-05-30 16:21:31 UTC
In file dialog "Filter" field, enter "*" and press enter. The files must appears...

I think a wrong filter type mime format is passed to the file dialog. That all...

Gilles Caulier
Comment 2 Sebastian 2017-05-31 12:45:30 UTC
(In reply to caulier.gilles from comment #1)
> In file dialog "Filter" field, enter "*" and press enter. The files must
> appears...
> 
> I think a wrong filter type mime format is passed to the file dialog. That
> all...
> 
> Gilles Caulier

Thanks Gilles, I assume by "Filter" field you mean "Files of type:". I can't find anything in the dialog that says "Filter". 

Nevertheless, if you look at the the screen-shot I provided, the "Files of type:" field already already says "ICC Files (*.icc; *.icm)". There's no way of changing this value to "*" or anything else. All my files end in ".icc" so they should meet this filter, yet none get listed.
Comment 3 caulier.gilles 2017-05-31 13:07:20 UTC
With 5.6.0 pre-release AppImage Linux bundle you can because we don't use desktop file dialog now. Qt5 file dialog is used instead and the "Filter" field is editable.

https://www.flickr.com/photos/digikam/35011194985/in/dateposted-public/

In all cases, without to edit this field, the icc profiles are properly listed here in file dialog...

Please test with 5.6.0 bundle and report :

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Gilles Caulier
Comment 4 Sebastian 2017-05-31 21:16:27 UTC
Created attachment 105809 [details]
digiKam 5.6.0 pre-release file dialog
Comment 5 Sebastian 2017-05-31 21:17:25 UTC
Created attachment 105810 [details]
appmenu-qt & appmenu-qt5 installed
Comment 6 Sebastian 2017-05-31 21:18:20 UTC
(In reply to caulier.gilles from comment #3)
> With 5.6.0 pre-release AppImage Linux bundle you can because we don't use
> desktop file dialog now. Qt5 file dialog is used instead and the "Filter"
> field is editable.
> 
> https://www.flickr.com/photos/digikam/35011194985/in/dateposted-public/
> 
> In all cases, without to edit this field, the icc profiles are properly
> listed here in file dialog...
> 
> Please test with 5.6.0 bundle and report :
> 
> https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM
> 
> Gilles Caulier

Thanks Gilles, I've tried it with the 5.6.0 AppImage however it still doesn't appear to use the Qt5 file dialog (see attached screenshot). I checked on Synaptic PM and it seems I have both appmenu-qt and appmenu-qt5 installed (see attached screenshot).
Comment 7 Christoph Feck 2017-06-05 21:59:26 UTC
Screenshot from comment #3 shows KDE dialog, screenshot from comment #4 shows Qt5 dialog.

Applications only get the KDE dialog, if they are run under the KDE Plasma desktop, and Qt5 dialogs are not forced.
Comment 8 caulier.gilles 2017-06-06 07:16:39 UTC
Git commit 18189cd53354ac603a8522906052fe5b9b6e47c3 by Gilles Caulier.
Committed on 06/06/2017 at 07:15.
Pushed by cgilles into branch 'master'.

use space instead ';' as type mime separator for file dialog.
tested with Gnome based file dialog, and it work fine.
FIXED-IN: 5.6.0

M  +5    -4    NEWS
M  +2    -1    libs/widgets/files/dfileselector.cpp
M  +1    -1    libs/widgets/files/dfileselector.h
M  +2    -2    libs/widgets/files/drawdecoderwidget.cpp
M  +1    -1    utilities/imageeditor/rawimport/rawsettingsbox.cpp

https://commits.kde.org/digikam/18189cd53354ac603a8522906052fe5b9b6e47c3