Bug 380123 - Documentation browser history ignores followed links
Summary: Documentation browser history ignores followed links
Status: RESOLVED FIXED
Alias: None
Product: kdevelop
Classification: Applications
Component: Documentation viewer (other bugs)
Version First Reported In: git master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-23 16:25 UTC by Friedrich W. H. Kossebau
Modified: 2022-11-30 17:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Friedrich W. H. Kossebau 2017-05-23 16:25:45 UTC
Since the change to QtWebEngine the documentation browser history ignores any links navigated to by activating them e.g. by mouse clicks.

By what I found for now seems https://cgit.kde.org/kdevelop.git/commit/?id=8a1536caf85f402d6d1c2d6cb00b0b94d34196bb broke this by removing
QObject::connect(view, &StandardDocumentationView::linkClicked, this, &QtHelpDocumentation::jumpedTo); but without ensuring a proper replacement in the new design (apol: "now we are delegating links", "the view is navigating wherever it goes").

When fixing this bug, all the still existing jumpedTo() methods possibly should be removed then as well, given they seem no longer called by anything.
Comment 1 Piotr Mierzwinski 2017-10-12 22:17:12 UTC
I'm not sure if this is related, but in version 5.1.80, and coming from 5.2 branch (nightly build) doesn't work any links in Qt5 documentation (clicked by LMB). Or in other words. Doesn't work navigation in opened documentation for Qt5.

Tested on KDevelop-git-x86_64.AppImage and KDevelop-5.1.80-x86_64.AppImage (downloaded at 2017-10-11) accordingly.

And second thing is not readable ComboBox at left side of edit field. I mean after I find, for example, documentation for QPlainTextEdit I see there "QtWidget", when I open this Combo I see very short strings looking like: 
"q..d"
"q..s"
"q..p"
etc.

And third thing.
Continue previous case. When I click on "Home" button, it moves me to Qt Widgets - I see only one entry in tree view, I mean: Qt Widgets", whereas I expected it will move me to "QtHelp Home Page". Workaround is choosing  from Combo (showing QtWidget) last item with name "Q..p", which moves me to actual "QtHelp Home Page".
Comment 2 Justin Zobel 2022-11-10 08:51:48 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 3 Bug Janitor Service 2022-11-25 05:16:57 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Piotr Mierzwinski 2022-11-30 17:39:55 UTC
I retested this issue with recent version of KDevelop and seems now it works.

Tested with:
KDevelop version 5.9.221170 (22.11.70)

$ apt show kdevelop
Package: kdevelop
Version: 4:22.08.1+p22.04+tunstable+git20221012.0016-0

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.26.80
KDE Frameworks Version: 5.101.0
Qt Version: 5.15.7
Kernel Version: 5.15.0-53-generic (64-bit)
Graphics Platform: X11
Graphics Processor: Mesa Intel® Xe Graphics