Bug 380058 - Option to hide command messages (like topic and mode messages) from channel buffers
Summary: Option to hide command messages (like topic and mode messages) from channel b...
Status: REPORTED
Alias: None
Product: konversation
Classification: Applications
Component: ignore (show other bugs)
Version: 1.7.2
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-21 19:14 UTC by Frank Fischer
Modified: 2017-06-13 21:38 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to hide command messages from channel buffers. (1.30 KB, patch)
2017-05-21 19:14 UTC, Frank Fischer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Fischer 2017-05-21 19:14:07 UTC
Created attachment 105662 [details]
Patch to hide command messages from channel buffers.

When entering a channel konversation shows several command messages like the topic, who set the topic, channel modes. These messages are also shown if the server connection is lost (e.g. due to suspend of the machine) and reestablished.

As the channel modes and topics seldom change, the buffers (especially if they have low traffic) are just flooded with completely equal messages (if you use a laptop you might reconnect several times a day).

AFAICT it is sufficient to modify `appendCommandMessageToChannel` and `appendCommandMessage` methods to get the desired behaviour. I have append a patch that hides these messages if the hide join/part option is set. Probably this is not the best option and one should add another configuration option to do the same.
Comment 1 Christoph Feck 2017-06-07 10:31:34 UTC
We use Phabricator for patch review. Please add your patch there using https://phabricator.kde.org/differential/diff/create/ and selecting Konversation repository.
Comment 2 Frank Fischer 2017-06-07 19:40:08 UTC
I can do this. But this was not meant to be a patch, just an illustration what I did as a quick hack. I rather thought to start a discussion whether my requested feature should be implemented and how, and then I could try to craft a proper patch. But maybe phabricator is the right place to do this?
Comment 3 Christoph Feck 2017-06-13 21:38:01 UTC
Yes, phabricator is the right tool, because people can add comments at specific code line changes. If you are really unsure, ask on the mailing list first.

https://mail.kde.org/mailman/listinfo/konversation-devel