Bug 379894 - kickoff launcher: in rtl layout and vertical panel, the arrow keys and Esc not work as expected
Summary: kickoff launcher: in rtl layout and vertical panel, the arrow keys and Esc no...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) widget (show other bugs)
Version: 5.9.4
Platform: Ubuntu Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-16 09:52 UTC by Hamidreza Jafari
Modified: 2017-07-03 10:31 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hamidreza Jafari 2017-05-16 09:52:10 UTC
Hello,

In RTL pressing up/down/escape only moves to the left page as if you are sending a left keystroke. Up/down should move focus to the upper or lower item and escape should presumably close the launcher.
Comment 1 ttv200 2017-05-18 22:06:12 UTC
I check also in RTL layout, but it's only in RTL.

I'll check, maybe I can fix it
Comment 2 ttv200 2017-05-18 22:14:31 UTC
It isn't only the arrow keys, every key except right arrow change to the next category
Even special keys (Ctrl, Shift, Caps Lock...)
Comment 3 David Edmundson 2017-07-03 10:31:57 UTC
Git commit 06410e779b4fac87bed45df6b70bc54fcd0c0c0e by David Edmundson.
Committed on 03/07/2017 at 10:31.
Pushed by davidedmundson into branch 'master'.

Fix tab bar layout key handling in RTL

Summary:
Current code will, when mirrored, treat all keys like they're the left
key.

Test Plan: Ran plasma in RTL

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel, #frameworks

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D6480

M  +1    -1    src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml

https://commits.kde.org/plasma-framework/06410e779b4fac87bed45df6b70bc54fcd0c0c0e