Bug 379888 - [Feature Request] - Force the FolderView widget in CompactRepresentation when in panel
Summary: [Feature Request] - Force the FolderView widget in CompactRepresentation when...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-16 07:12 UTC by Michail Vourlakos
Modified: 2018-03-25 08:37 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michail Vourlakos 2017-05-16 07:12:20 UTC
I would like to investigate if such behavior from folderView widget is considered a design decision and if there are ways to improve this a bit..

Currently the Folder Widget (I know that this isnt a clear plasma widget but the FolderView Desktop in compact mode) when it is in the panel it shows an icon but when the panel grows (in thickness) the icon changes to present the contents of the folder.

Would you consider to prevent this when the folder widget is in the panel or to include a user configuration option instead?

I looked into the code and I didnt find a FullRepresentation, only a CompactRepresentation. I suppose that this means that because there arent Layout.minimum...s used from a fullRepresentation, some defaults are used to trigger the CompactRepresentation or  the folderViewLayer presentation


the issue is very obvious with Latte dock because of the parabolic effect, during the animation the presentation of the folderView widget changes from an icon to a list of files and vice versa

thanks a lot
Comment 1 Eike Hein 2017-05-16 07:16:02 UTC
On master this is actually a non-issue currently. The recent changes to make panel icons follow System Settings -> Icons -> Advanced -> Panel -> Size as maximum size means the FV applet can't get big enough anymore to switch representations. However I don't know if these changes might interfere with your thing in a different way. Please make sure you try Latte against master.
Comment 2 Michail Vourlakos 2017-05-16 09:11:56 UTC
(In reply to Eike Hein from comment #1)
> On master this is actually a non-issue currently. The recent changes to make
> panel icons follow System Settings -> Icons -> Advanced -> Panel -> Size as
> maximum size means the FV applet can't get big enough anymore to switch
> representations. However I don't know if these changes might interfere with
> your thing in a different way. Please make sure you try Latte against master.

you are right, I hadnt considered how this change would influence the applets presence in Latte. I have some ideas of what would happen and possible solutions from our side. The fact that the presentation doesnt change any more is a good thing, how Latte will represent it to the user it may be fixable and workable from Latte side now.

I will review with plasma 5.10 and give an update in this...
Comment 3 Michail Vourlakos 2017-05-23 09:27:44 UTC
(In reply to Eike Hein from comment #1)
> On master this is actually a non-issue currently. The recent changes to make
> panel icons follow System Settings -> Icons -> Advanced -> Panel -> Size as
> maximum size means the FV applet can't get big enough anymore to switch
> representations. However I don't know if these changes might interfere with
> your thing in a different way. Please make sure you try Latte against master.

Eike an update on this...

By using latest master the issue for Latte is not fixed.

What is happening is that probably for plasma the space used for the folderview applet in the panel is provided and limited by the panel containment but for Latte we want bigger sizes than the one set in systemsettings.
So in Latte the folderview applet grows in bigger size. In such case in my system the folderview changes to FullRepresentation after 96px. so I have to limit specifically the folderview at that size in order to not show the list of files in the panel.

I could send a patch for this in order for CompactRepresentation of folderview:

1. add a setting in folderview configuration window to never show the file list when it is in a panel (always show the icon in such case)

or

2. make this the default behavior, at any case the folderview widget to never show its contents in the panel


but of course, I dont know if that follows the plasma design decisions and I need first a confirmation.
Comment 4 Michail Vourlakos 2017-06-10 16:22:02 UTC
An update on this for Plasma 5.10, I have set panel icon size to 256px.  the forlderview still changes its representation to file list at some point when it is in the plasma panel
Comment 5 Eike Hein 2017-06-12 10:11:54 UTC
I mean ... it's supposed to though, for people who want sidebar panels etc. Marco, is there a way their containment could force a particular repr?
Comment 6 Eike Hein 2017-06-19 10:29:48 UTC
Git commit 84300b516b799fae94fefd7a9a418e5584d37987 by Eike Hein.
Committed on 19/06/2017 at 10:19.
Pushed by hein into branch 'Plasma/5.8'.

Fix DND onto Task Manager for groups, group dialog scrollbar

Summary:
With this patch drag-hover activation will work for group children,
and moving between different group parents while dragging will
correctly refresh the dialog contents.
Related: bug 379037

The patch also makes GroupDialog more similar to CompactApplet in
desktoppackage/, in particular managing applet status and activa-
ting the window explicitly. There is no concrete reason for this,
but it seemed like a good idea while debugging the DND issues.

Further, while inverting the MouseHandler<>ScrollArea nesting I
removed some dodgy geometry-setting code for the inside item, and
the ScrollArea viewport now is a single item. This very likely
addresses some reports that the scrollbar sometimes wouldn't appear
when required.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6231

M  +88   -53   applets/taskmanager/package/contents/ui/GroupDialog.qml

https://commits.kde.org/plasma-desktop/84300b516b799fae94fefd7a9a418e5584d37987
Comment 7 Eike Hein 2017-06-20 09:57:51 UTC
Wrong bug number in commit, thanks Christoph.
Comment 8 Michail Vourlakos 2018-03-25 08:37:46 UTC
Git commit 2683d4c6e60a9b8cca32f9b342d9010f4cc46086 by Michail Vourlakos.
Committed on 25/03/2018 at 08:37.
Pushed by mvourlakos into branch 'master'.

FolderView applet respect panel maxIcon size

Summary:
--FolderView takes into account the
units.iconSizeHints.panel value when is in panel
in order to switch its appearance from
CompactRepresentation to FullRepresentation
and vice versa.

Test Plan:
confirm that in order for FolderView to change to
FullRepresention when it is in panel, it respects
the units.iconSizeHints.panel value.

Reviewers: #plasma, hein, mart

Reviewed By: #plasma, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11651

M  +2    -2    containments/desktop/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/2683d4c6e60a9b8cca32f9b342d9010f4cc46086