Bug 379875 - Wrong icon name: weather-none should be weather-none-available
Summary: Wrong icon name: weather-none should be weather-none-available
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-15 20:56 UTC by Friedrich W. H. Kossebau
Modified: 2018-01-05 21:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Friedrich W. H. Kossebau 2017-05-15 20:56:12 UTC
The icon has been named "weather-none-available" since ever, and also still is in Oxygen and used as such, cmp. https://lxr.kde.org/search?_filestring=&_string=weather-none

While "weather-none-available" might not be the best icon name, it's still the icon name used also outside KDE repos, either in themes (e.g. Numix) or code (https://github.com/librehat/com.librehat.yahooweather/search?q=weather-none-available).

One could argue that the icon fallback mechanism should still result in "weather-none" being used with Breeze. Issues are that it still is unbalanced with other icon themes (incl. Oxygen). And fails with distributions patching the Breeze theme to inherit Oxygen, as then the Oxygen icon will be used.
So sticking with the historic full name would be less challenging.
Comment 1 Friedrich W. H. Kossebau 2018-01-05 21:54:48 UTC
Git commit 87cef4dd7856137e607137241c139f3ee3dbff75 by Friedrich W. H. Kossebau.
Committed on 05/01/2018 at 21:54.
Pushed by kossebau into branch 'master'.

Fix icon name "weather-none" -> "weather-none-available"

Summary:
"weather-none-available" has been the traditional name in Oxygen and
is referenced as such in existing KDE and non-KDE code, also used as
name in other icon themes (e.g. Numix).

One could argue that the icon fallback mechanism should still result
in "weather-none" being used with Breeze. Issues with that though are:
* is inconsistent naming with other icon themes (incl. Oxygen)
* fails with distributions patching the Breeze theme to inherit Oxygen,
  as then the Oxygen icon will be used.

Reviewers: #frameworks, #breeze, andreask

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D9626

R  +0    -0    icons-dark/applets/48/weather-none-available.svg [from: icons-dark/applets/48/weather-none.svg - 100% similarity]
R  +0    -0    icons/applets/48/weather-none-available.svg [from: icons/applets/48/weather-none.svg - 100% similarity]

https://commits.kde.org/breeze-icons/87cef4dd7856137e607137241c139f3ee3dbff75