Bug 379800 - Folder panel active text color incorrect assigned to WindowText color
Summary: Folder panel active text color incorrect assigned to WindowText color
Status: RESOLVED WORKSFORME
Alias: None
Product: dolphin
Classification: Applications
Component: panels: folders (show other bugs)
Version: 17.04.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2017-05-14 01:54 UTC by andre.cbarros
Modified: 2018-10-29 02:11 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Sensible active text color for folders panel (1.31 KB, patch)
2017-05-14 01:56 UTC, andre.cbarros
Details
Highlighting the problem of low contrast (58.64 KB, image/jpeg)
2017-06-01 18:57 UTC, andre.cbarros
Details
Highlighting the problem of low contrast 2 (58.25 KB, image/jpeg)
2017-06-01 18:58 UTC, andre.cbarros
Details
Highlighting the problem of low contrast 3 (57.88 KB, image/jpeg)
2017-06-01 18:58 UTC, andre.cbarros
Details
Highlighting the problem of low contrast 4 (58.51 KB, image/jpeg)
2017-06-01 18:59 UTC, andre.cbarros
Details
Highlighting the problem of low contrast 5 (57.85 KB, image/jpeg)
2017-06-01 19:00 UTC, andre.cbarros
Details
Highlighting the problem of low contrast 6 (57.41 KB, image/jpeg)
2017-06-01 19:01 UTC, andre.cbarros
Details
Color scheme used (2.35 KB, text/plain)
2017-06-01 19:05 UTC, andre.cbarros
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andre.cbarros 2017-05-14 01:54:05 UTC
This is an old bug (at least it so seems to me) unveiled when using dark themes with KDE.

To see it you need to set a theme that has dark colours for menu and windows and light colours for text. When you click on dolphin tree panel (that has window colours) and choose to rename a directory, the characters will have low contrast.

There is a patch attached. If you want want screenshots I will provide (I will need to revert to an unpatched binary before, of course).

To apply the patch just invoke it with patch -p1 under dolphin root tree.
Comment 1 andre.cbarros 2017-05-14 01:56:33 UTC
Created attachment 105522 [details]
Sensible active text color for folders panel
Comment 2 Christoph Feck 2017-05-31 21:44:51 UTC
Could you verify with the CheckColorRoles color scheme?
Comment 3 andre.cbarros 2017-06-01 18:54:05 UTC
OK, I will post here some screen shots so that things can be clear.

The problem arises from the following: when you try to rename a folder on folder panel it uses "view color" as background so, it logically should pick "view text" ("active text") when editing, but it does not, it picks "window text", and as so, may use a low contrast pick.

Regards,
Andre
Comment 4 andre.cbarros 2017-06-01 18:57:00 UTC
Created attachment 105827 [details]
Highlighting the problem of low contrast
Comment 5 andre.cbarros 2017-06-01 18:58:13 UTC
Created attachment 105828 [details]
Highlighting the problem of low contrast 2
Comment 6 andre.cbarros 2017-06-01 18:58:53 UTC
Created attachment 105829 [details]
Highlighting the problem of low contrast 3
Comment 7 andre.cbarros 2017-06-01 18:59:35 UTC
Created attachment 105830 [details]
Highlighting the problem of low contrast 4
Comment 8 andre.cbarros 2017-06-01 19:00:18 UTC
Created attachment 105831 [details]
Highlighting the problem of low contrast 5
Comment 9 andre.cbarros 2017-06-01 19:01:37 UTC
Created attachment 105832 [details]
Highlighting the problem of low contrast 6
Comment 10 andre.cbarros 2017-06-01 19:05:21 UTC
Created attachment 105833 [details]
Color scheme used
Comment 11 andre.cbarros 2017-06-01 19:07:52 UTC
Comment on attachment 105827 [details]
Highlighting the problem of low contrast

patched and only positioned
Comment 12 andre.cbarros 2017-06-01 19:08:32 UTC
Comment on attachment 105522 [details]
Sensible active text color for folders panel

patched and only positioned
Comment 13 andre.cbarros 2017-06-01 19:10:19 UTC
Comment on attachment 105828 [details]
Highlighting the problem of low contrast 2

patched and selected
Comment 14 andre.cbarros 2017-06-01 19:11:04 UTC
Comment on attachment 105827 [details]
Highlighting the problem of low contrast

patched and only positioned
Comment 15 andre.cbarros 2017-06-01 19:19:43 UTC
I must add that this problem does not happens on dolphin alone, even on "Color - System Settings" main window the problem of using "Window text" insttead of "Active text" is displayed.

Please, Try the color scheme by yourself before reaching a conclusion.

Regards,
Andre
Comment 16 Christoph Feck 2017-06-02 17:35:58 UTC
I explicitely requested testing with the CheckColorRoles color scheme.
Comment 17 andre.cbarros 2017-06-05 13:16:25 UTC
(In reply to Christoph Feck from comment #16)
> I explicitely requested testing with the CheckColorRoles color scheme.

Sorry, but CheckColorRoles is to check an application for misuse of colors by accident. It means nothing in this case as Dolphin is not coded by me and it only validates the use of colors to this particular scheme. What I´m reporting, granted, a bit unclearly, is that there is a fault in the logical of picking a particular color for Dolphin on folders panel when you try to rename a folder there. That CheckColorRoles can survive this test does not mean that it is the correct behavior, only that the bug is not disclosed on this particular color scheme.

Please, try the color scheme I posted and see by yourself. As I said, this does not affect only Dolphin but, on different applications, different particular uses of colors. KDE should have a better guide about it but, unluckily it does not.
Comment 18 Christoph Feck 2017-06-07 16:32:41 UTC
I can confirm that the current (unpatched) colors are wrong, but I need to check if your patch is correct. From looking at the patch and your screen shots, I cannot decide that. Please show the screen shots with the CheckColorRoles theme (before/after patch).

If this also affects other applications, could you report those separately?
Comment 19 andre.cbarros 2017-06-08 01:27:14 UTC
Sure, I can report where other applications fall short but I need do dig the source files to pick the exactly cases.

I will send what you requested tomorrow (no time today).

Regards,
Andre
Comment 20 Christoph Feck 2017-06-19 23:20:13 UTC
Still waiting for investigation.
Comment 21 Julian Steinmann 2018-04-12 09:23:41 UTC
Any updates on the investigations?
Comment 22 Julian Steinmann 2018-04-28 11:50:27 UTC
Still waiting for an update. Should we still keep this report open? The issue could still exist, but we do not have all necessary information to fix it.
Comment 23 andre.cbarros 2018-04-28 14:43:39 UTC
(In reply to Julian Schraner from comment #22)
> Still waiting for an update. Should we still keep this report open? The
> issue could still exist, but we do not have all necessary information to fix
> it.

To me the reasoning holds true. I think I reported it to Dolphin development list. Will check there again.
Comment 24 andre.cbarros 2018-04-28 14:47:04 UTC
By the way, I will be working on some other "defective" patch to Dolphin this weekend and will check the status of this specific issue on the development list again.
Comment 25 Andrew Crouthamel 2018-09-28 03:28:23 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 26 Andrew Crouthamel 2018-10-29 02:11:15 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!