Bug 379740 - Build fails with CLang
Summary: Build fails with CLang
Status: RESOLVED FIXED
Alias: None
Product: Powerdevil
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Development Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-12 06:59 UTC by Christophe Marin
Modified: 2017-05-12 08:51 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/powerdevil/3c17ba7612797d5b6ee86ac023991d5592fbca1a
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Christophe Marin 2017-05-12 06:59:12 UTC 
/kde/src/5/powerdevil/kcmodule/global/GeneralPage.cpp:127:111: error: 'changed' is a protected member of 'KCModule'
    connect(pausePlayersCheckBox, &QCheckBox::stateChanged, this, static_cast<void(KCModule::*)()>(&KCModule::changed));
                                                                                                    ~~~~~~~~~~^~~~~~~
/kde/inst/5/include/KF5/KConfigWidgets/kcmodule.h:375:10: note: must name member using the type of the current context 'GeneralPage'
    void changed();
         ^
Comment 1 Christophe Marin 2017-05-12 07:01:21 UTC 
Jonathan, this code is also in the plasma release (and 	Kai Uwe Broulik is on vacation)
Comment 2 Bhushan Shah 2017-05-12 08:51:26 UTC 
Git commit 3c17ba7612797d5b6ee86ac023991d5592fbca1a by Bhushan Shah.
Committed on 12/05/2017 at 08:47.
Pushed by bshah into branch 'Plasma/5.10'.

Use old style connect syntax

Otherwise it breaks build on some compilers like clang

M  +1    -1    kcmodule/global/GeneralPage.cpp

https://commits.kde.org/powerdevil/3c17ba7612797d5b6ee86ac023991d5592fbca1a