Hi. I think that would be great for the color adjustment curves this list of improvements: 1-Flexible histogram layout. Right now the histogram has a fixed size, and is a very little size. A flexible size that adapts to the parent window size would be better. 2-Logarythmic scale. Sometimes is necessary 3-Reset channel button, now for resetting the curves I need to cancel the operation and reopen the tool, loosing the other curves in other channels 4-Histogram view in the RGBA and Luminosity channels All of this is in the Gimp's adjustment curves tool, and are little details that made using the tool more easily
Yeah, well... This is something that just needs someone to start coding. The code itself isn't complex, it's nicely separated from the rest of Krita, so one wouldn't need much knowledge to get started on it. It's unlikely that someone on the core team will ever find time for it, though!
Hi, I am willing to get started on that job. However, I am new to KDE and have not used Qt in a while. Any indication where I should start?
Hi Isabelle, I see in my irc backlog that you tried to ask questions -- unfortunately, almost all of us are in timezones where one is usually in bed when you asked your question. KDE isn't that relevant -- we use some frameworks, but the most important thing is Qt. In any case, you wrote on irc that you have already gotten Krita built and installed, which is the biggest step. Shreyas already worked on part of this wish: enabling the logarithmic view in the histograms, but I he added that to the levels filter. If you check his diff, that would be a starting point for adding the same switch to the curves filter: https://phabricator.kde.org/D6621 The reset button would be simply a push button you add to the ui file. The relevant code is in krita/plugins/filters/colorsfilters, wdg_perchannel.ui kis_perchannel_filter.cpp kis_perchannel_filter.h Good luck!
(In reply to Boudewijn Rempt from comment #3) > Hi Isabelle, > > I see in my irc backlog that you tried to ask questions -- unfortunately, > almost all of us are in timezones where one is usually in bed when you asked > your question. > > KDE isn't that relevant -- we use some frameworks, but the most important > thing is Qt. In any case, you wrote on irc that you have already gotten > Krita built and installed, which is the biggest step. Shreyas already worked > on part of this wish: enabling the logarithmic view in the histograms, but I > he added that to the levels filter. If you check his diff, that would be a > starting point for adding the same switch to the curves filter: > https://phabricator.kde.org/D6621 > > The reset button would be simply a push button you add to the ui file. > > The relevant code is in krita/plugins/filters/colorsfilters, > > wdg_perchannel.ui > kis_perchannel_filter.cpp > kis_perchannel_filter.h > > Good luck! Hi, I fixed some issues. 1)Added a reset button in color adjustment curve. 2)Made flexible histogram layout. How should I contribute it to the project?
Created attachment 109490 [details] Patch file of diff in src directory Patch file for changes in code. Patch is diff file in src directory. 1)Added a reset button to color adjustment curve. 2)Made flexible histogram layout. file changed:- kis_curve_widget.cpp kis_perchannel_filter.cpp kis_perchannel_filter.h wdg_perchannel.ui
Thanks! The patch didn't apply cleanly, but I think I managed to apply it and I'll check it now.
Everything seems to work, but the layout is a bit wonky. I think that putting the reset button to the right of the logarithmic checkbox might work better.
Created attachment 109491 [details] diff patch for wdg_perchannel.ui updated
Git commit 8ca5abd4c3c4836aa3937e3f22f98b6453366647 by Boudewijn Rempt. Committed on 23/12/2017 at 10:20. Pushed by rempt into branch 'master'. Add a reset button to the per-channel filter And make the curves widget stretchable. CCMAIL:22shubh22@gmail.com Patch by Shubham Goyal. Thanks! M +5 -0 libs/ui/widgets/kis_curve_widget.cpp M +8 -1 plugins/filters/colorsfilters/kis_perchannel_filter.cpp M +3 -0 plugins/filters/colorsfilters/kis_perchannel_filter.h M +157 -114 plugins/filters/colorsfilters/wdg_perchannel.ui https://commits.kde.org/krita/8ca5abd4c3c4836aa3937e3f22f98b6453366647
Thanks! This worked fine, and I've pushed the patch :-)