Bug 379487 - Elisa doesn’t handle non-default font/display settings
Summary: Elisa doesn’t handle non-default font/display settings
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-03 19:04 UTC by Karl Ove Hufthammer
Modified: 2017-05-16 06:26 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot showing layout problems in Elisa (78.19 KB, image/png)
2017-05-03 19:04 UTC, Karl Ove Hufthammer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Ove Hufthammer 2017-05-03 19:04:14 UTC
Created attachment 105327 [details]
Screenshot showing layout problems in Elisa

Elisa doesn’t seem to handle non-default font/display settings properly. It’s a bit difficult to explain the problem, so I’ll attach a screenshot showing how Elisa looks on my system.

Here’s the problems I observe:

- Overlapping text
- Too small spacing between lines of text
- Inconsistent font size
- Parts of application window hidden (lower right part)
- Non-working widgets (because of overlapping text)

Note that I use a larger font size than the default. Other KDE applications handle this fine, but Elisa doesn’t. (Perhaps due to pixel-based hardcoding of element positions instead of letting Qt and its layout algorithms take care of it?)
Comment 1 Matthieu Gallien 2017-05-04 14:28:45 UTC
What settings are you exactly using ?

I am doing some tests and fixing issues I can identify. For example, I am testing font sizes of 8, 12 and 16. This has allowed me to identify some problems I am fixing.
Other issues I cannot reproduce cannot be fixed by me. This is why I need more help from you even if I appreciate the screenshot.

Best regards
Comment 2 Karl Ove Hufthammer 2017-05-04 16:14:52 UTC
For the ‘General’ font settings, I’m using the font ‘Source Sans Pro’ at font size 18. (This may sound like a very large font size, but I’m using my TV as a monitor, viewing the screen from several meters away.)

I also use the ‘Breeze’ theme. I’ll be happy to report any other settings that I use that might be of interest. I can also download the latest Git version of Elisa to test any changes.
Comment 3 Matthieu Gallien 2017-05-05 19:19:41 UTC
I did some tests using my TV screen. In my case some elements are correctly sized and others are too big. I am a bit surprised as in your case, the play button is too small. This is the opposite.
Anyway, I am working on this issue.
Comment 4 Karl Ove Hufthammer 2017-05-06 08:13:05 UTC
I don’t know much about QtQuick, but it seems like you’re trying setting too many options when defining the buttons. Instead of

            Image {
                 … 20–30 lines of code defining the layout …
            }

a simple

            ToolButton {
                iconSource: elisaTheme.pauseIcon
                onClicked: … do something …
            }

(within a ‘ToolBar’ control) should work, and will automatically use the platform’s preferred icon size.
Comment 5 Matthieu Gallien 2017-05-16 06:26:14 UTC
Git commit a2d80144ba019c277b85b51c27ecf924f6c8ed10 by Matthieu Gallien.
Committed on 16/05/2017 at 06:25.
Pushed by mgallien into branch 'master'.

calculate the height of grid cells using font metrics

M  +6    -1    src/MediaAllAlbumView.qml
M  +7    -2    src/MediaAllArtistView.qml
M  +6    -1    src/MediaArtistAlbumView.qml

https://commits.kde.org/elisa/a2d80144ba019c277b85b51c27ecf924f6c8ed10