Bug 378950 - widgets should all have size constraint property
Summary: widgets should all have size constraint property
Status: RESOLVED INTENTIONAL
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (other bugs)
Version First Reported In: 5.8.5
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-19 09:52 UTC by Aaron Peterson
Modified: 2017-04-23 23:25 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Peterson 2017-04-19 09:52:04 UTC
There are general, appearance and keyboard shortcut properties that should be pretty generic to all widgets...

If I use a vertical panel, I would want to limit the height of the kmenu... otherwise when I make it wide enough so I can read the items in the taskbar, the K takes half the screen.

It would be easiest and best to just make this be in the generic widget that all other widgets inherit from.  You could make it be overwritable if the widget decides to provide it's own... but this needs to communicate to the containment that this widget shall not exceed a certain dimension.
Comment 1 Manuel Ramírez 2017-04-20 10:38:08 UTC
I have posted a similar one the same day.
378958
Comment 2 David Edmundson 2017-04-23 22:51:30 UTC
We will try to fix the individual issues Manuel has pointed out. Feel free to list more.

Applets can already communicate sizes to the containment (min, preffered, max). So most your proposal is already done.

Adding a default to this base class (AppletInterface) won't actually solve the problem; as well as effectively being an API break for 3rd parties.
Comment 3 Manuel Ramírez 2017-04-23 23:25:31 UTC
Hi David.

Thank you for the reply.

With:
- "Applets can already communicate sizes to the containment (min, preffered, max). So most your proposal is already done."

You mean that this can be done with some configuration?

Regards.