Bug 378948 - PatchReview plugin should only handle DocumentController signals when active
Summary: PatchReview plugin should only handle DocumentController signals when active
Status: RESOLVED WORKSFORME
Alias: None
Product: kdevplatform
Classification: Developer tools
Component: patchreview (show other bugs)
Version: unspecified
Platform: Compiled Sources All
: NOR normal
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-19 09:33 UTC by RJVB
Modified: 2022-12-04 05:15 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
add an active state variable to PatchReviewPlugin (2.87 KB, patch)
2017-04-19 09:33 UTC, RJVB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description RJVB 2017-04-19 09:33:03 UTC
Created attachment 105090 [details]
add an active state variable to PatchReviewPlugin

As observed in the linked ticket, the PatchReview plugin should probably only process the subscribed DocumentController signals when it's actually being used.

The attached patch should ensure that by adding a state variable. The `m_patch` member variable was already being used for that but as far as I can tell it remains non-null when the plugin has been used once.
Comment 1 Justin Zobel 2022-11-04 03:10:36 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 2 Bug Janitor Service 2022-11-19 05:14:02 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Bug Janitor Service 2022-12-04 05:15:34 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!