Bug 378931 - Add ISA 3.0B additional isnstructions, add OV32, CA32 setting support
Summary: Add ISA 3.0B additional isnstructions, add OV32, CA32 setting support
Status: CLOSED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: vex (show other bugs)
Version: 3.10 SVN
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-18 18:42 UTC by Carl Love
Modified: 2017-05-10 15:22 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
ISA 3.0 additional instructions, fixes code changes only (101.19 KB, patch)
2017-04-21 20:07 UTC, Carl Love
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Love 2017-04-18 18:42:18 UTC
PPC64 ISA 3.0B, support for the additional instructions: addex, mffscdrn, mffscdrni, mffsce, mffscrn, mffscrni, mffsl. vmsumudm needs to be added.

Additionally, the OV32 and CA32 bits were introduced in ISA 3.0 but Valgrind is not supporting setting these bits for ISA 3.0
Comment 1 Carl Love 2017-04-21 20:07:01 UTC
Created attachment 105140 [details]
ISA 3.0 additional instructions, fixes code changes only

The attached patch adds the needed support for the additional instructions.  It also adds support for the OV32 and CA32 bits to the existing arithmetic instructions.  The issue here with the OV32 and CA32 bit is several of the existing test cases will now run differently on pre ISA3.0 HW versus ISA3.0 HW.  Valgrind will match the functionality of the pre ISA3.0 and ISA3.0 HW.  The older test cases were refactored to put the instructions that don't change into one test and the instruction that change into another.  This way we can now mininimize the size of the expect files for pre ISA 3.0 and ISA3.0 results. These changes to the test code is included in the patch.

I have not bothered to post the patch with the changes to the expect files.  I don't think that is of much interest but will be included when the patch is applied.

Please review the patch and let me know if you have any questions, comments or concerns.  Thanks.
Comment 2 Carl Love 2017-05-03 17:30:59 UTC
Attached patch was committed,  Vex commit 3359
The test case result files, test case changes are in Valgrind commit 16329

There is a lot of changes to the test case outputs.  I think it is all fine but will leave this Bug open until I verify the regression tests are OK.
Comment 3 Carl Love 2017-05-10 15:22:08 UTC
The nightly regression tests look fine.  Closing