Bug 378914 - Inefficient use of screen area in 'Grandfather'
Summary: Inefficient use of screen area in 'Grandfather'
Status: RESOLVED FIXED
Alias: None
Product: kpat
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Karl Ove Hufthammer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-18 09:49 UTC by TonyP
Modified: 2018-09-20 18:00 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 18.08.2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description TonyP 2017-04-18 09:49:25 UTC
If the foundation piles were moved to the side, rather than on top, Grandfather could be played with larger cards (compare Grandfather layout as it currently is, with the layout of Yukon). 
Not a big deal I know, but then it should be easy to implement the change.
Comment 1 Karl Ove Hufthammer 2018-09-15 14:22:50 UTC
I think the placement of the foundation pile is an integral part of the game, and preferably shouldn’t be changed. But by just reducing the space at the bottom, we should be able to reclaim some wasted space and make the cards much larger. I’ll work a patch for this.
Comment 2 Karl Ove Hufthammer 2018-09-20 18:00:32 UTC
Git commit eb5fa8dab3559bf008829154c4c17239af607da6 by Karl Ove Hufthammer.
Committed on 20/09/2018 at 18:00.
Pushed by huftis into branch 'Applications/18.08'.

Reduce wasted space for Klondike and Grandfather

Summary:
Klondike and (especially) Grandfather reserves a lot of
space at the bottom of the screen for long card piles.
This results in very small cards, which makes the game
uncomfortable to play, especially on smaller screens.

This commmit reduces the space reserved at the bottom
of the screen, which automatically enlarges the cards.
Long piles don’t pose a problem, as KPat automatically
compresses the cards to fit the screen.

Even with the reduced space, the colours and numbers are
still clearly visible, also in a ‘worst case’ scenario with very
long piles. (In these two game types, only the colour
(i.e. red vs. black) matter, not the suit, so it is not a
problem if the suits of the cards aren’t visible.)
Related: bug 307625

FIXED-IN: 18.08.2

Test Plan:
Play Grandfather and Klondike before and after this patch.
Note that the cards are much bigger after the patch
and that the numbers and colours are still clearly visible.

Reviewers: #kde_games, fabiank, mlaurent

Reviewed By: fabiank

Subscribers: kde-games-devel

Differential Revision: https://phabricator.kde.org/D15534

M  +1    -1    grandf.cpp
M  +1    -1    klondike.cpp

https://commits.kde.org/kpat/eb5fa8dab3559bf008829154c4c17239af607da6