Bug 378698 - Icons became too large
Summary: Icons became too large
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Edit Mode (show other bugs)
Version: 5.9.4
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
: 379572 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-04-12 14:22 UTC by qje
Modified: 2017-05-25 22:56 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
proof.jpg (48.31 KB, image/png)
2017-04-12 14:22 UTC, qje
Details
screen (24.91 KB, image/png)
2017-05-14 18:42 UTC, ntcr
Details
screen2 (18.00 KB, image/png)
2017-05-14 18:44 UTC, ntcr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description qje 2017-04-12 14:22:58 UTC
Created attachment 104989 [details]
proof.jpg

This happened after update to frameworks 5.33
Comment 1 Marco Martin 2017-04-13 11:41:14 UTC
fixed in 948ff63d65d2e645eeb023387600bee52ef4d684 in plasma-framework
Comment 2 David Edmundson 2017-04-13 16:23:21 UTC
Marco, Should do a 5.33.1 ?

We can't leave something this obvious for a whole month.

Either backport your fix, or just revert Eike's (as I think I saw some workspace changes too)
Comment 3 David Edmundson 2017-04-13 16:23:30 UTC
Also, is this related: https://bugs.kde.org/show_bug.cgi?id=378700
Comment 4 Rex Dieter 2017-04-13 17:18:21 UTC
I don't see any commit 948ff63d65d2e645eeb023387600bee52ef4d684 in plasma-framework

This one perhaps?

https://cgit.kde.org/plasma-framework.git/commit/?id=fb8ed07651a7101c2f9c41c6e6676ac8196c1225
Comment 5 David Edmundson 2017-04-13 22:51:25 UTC
This one is actually fixed by e28ea7a47c9669f232b05451e20d001ca61cd2c4 in plasma-desktop.
The plasma-desktop code was technically wrong, but the fact that we made that change is really bad.

Patching workspace to handle a frameworks change is *always always* wrong.
It means that we've noticed that there's a break that's going to affect all our stable users and then knowingly just left it and fixed the symptom.
Comment 6 David Edmundson 2017-04-14 08:56:36 UTC
fb8ed07651a7101c2f9c41c6e6676ac8196c1225 is the commit in p-f that Marco was referring to which is also needed for this
Comment 7 bpp 2017-04-26 04:32:27 UTC
I just updated to 5.9.5 and it doesn't fixed here. So I have to wait 20 days 'till you guys release 5.34? Is there a some kind of file which I should edit to fix it (and https://bugs.kde.org/show_bug.cgi?id=378700 too)? With instruction please.
Comment 8 David Edmundson 2017-05-06 09:44:46 UTC
*** Bug 379572 has been marked as a duplicate of this bug. ***
Comment 9 ntcr 2017-05-14 18:42:54 UTC
Created attachment 105537 [details]
screen

There is also too big icon for gwenview
Comment 10 ntcr 2017-05-14 18:44:44 UTC
Created attachment 105538 [details]
screen2

and for flash device before clicking for actions
Comment 11 ntcr 2017-05-14 18:46:38 UTC
and that goddamn gap on the right discribed in https://bugs.kde.org/show_bug.cgi?id=378700 (seems that devs ignoring that bug)