Bug 378684 - Incorrect page width for plain text messages
Summary: Incorrect page width for plain text messages
Status: RESOLVED UPSTREAM
Alias: None
Product: trojita
Classification: Applications
Component: Desktop GUI (show other bugs)
Version: git
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Trojita default assignee
URL:
Keywords:
: 381353 383045 383478 384339 410706 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-04-12 07:36 UTC by Unknown
Modified: 2019-08-07 22:18 UTC (History)
10 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot (56.92 KB, image/png)
2017-04-12 07:36 UTC, Unknown
Details
initial fix of the plain text issue, uses webwngine. WIP. (33.78 KB, patch)
2017-10-17 19:56 UTC, Jesper Schmitz Mouridsen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Unknown 2017-04-12 07:36:36 UTC
Created attachment 104981 [details]
screenshot

Plain text messages without any corresponding HTML version are displayed with a page width of only 2 characters. This problem happens on both Trojita 0.7 and Trojita git. I suspect this problem is due to having upgraded qtwebkit from version 5.7.1 to version 6.0, but I'm not sure. My GNU/Linux distribution is Gentoo Linux.
Comment 1 Jan Kundrát 2017-04-12 07:50:37 UTC
Yeah, it's likely a regression in their unofficial port of a new upstream webkit to Qt. As far as I can tell, Gentoo doesn't really ship that fork in their official repositories. Please report this to the forked QtWebKit upstream, we cannot really fix their regressions.
Comment 2 Unknown 2017-04-12 08:50:50 UTC
I filed an issue on the QtWebKit bug tracker: https://github.com/annulen/webkit/issues/511
Comment 3 Jan Kundrát 2017-06-19 06:13:48 UTC
*** Bug 381353 has been marked as a duplicate of this bug. ***
Comment 4 Elvis Angelaccio 2017-08-02 13:49:43 UTC
*** Bug 383045 has been marked as a duplicate of this bug. ***
Comment 5 Thomas Lübking 2017-08-14 06:40:09 UTC
*** Bug 383478 has been marked as a duplicate of this bug. ***
Comment 6 Heiko Becker 2017-09-04 09:23:18 UTC
*** Bug 384339 has been marked as a duplicate of this bug. ***
Comment 7 kavol 2017-09-04 10:09:36 UTC
hmm ... please could you consider keeping this open until fixed to prevent duplicates, as closed bugs don't show in the search linked from Trojitá's homepage?
Comment 8 Jesper Schmitz Mouridsen 2017-10-17 19:56:23 UTC
Created attachment 108411 [details]
initial fix of  the plain text issue, uses webwngine. WIP.

https://github.com/jsm222/trojita/tree/v0.7-webengine
Comment 9 Jan Kundrát 2017-10-18 08:37:41 UTC
(In reply to Jesper Schmitz Mouridsen from comment #8)
> initial fix of  the plain text issue, uses webwngine. WIP.

Cool! Thanks, yes, adding a QWebEngine backend to be used as an alternative to the legacy QWebKit backend is definitely a way to go. Please make that at least buildtime-configurable, though, and submit these patches via Gerrit. See https://techbase.kde.org/Development/Gerrit for a small howto.
Comment 10 Jesper Schmitz Mouridsen 2017-10-19 09:30:04 UTC
(In reply to Jan Kundrát from comment #9)
> (In reply to Jesper Schmitz Mouridsen from comment #8)
> > initial fix of  the plain text issue, uses webwngine. WIP.
> 
> Cool! Thanks, yes, adding a QWebEngine backend to be used as an alternative
> to the legacy QWebKit backend is definitely a way to go. Please make that at
> least buildtime-configurable, though, and submit these patches via Gerrit.
> See https://techbase.kde.org/Development/Gerrit for a small howto.

Done https://gerrit.vesnicky.cesnet.cz/r/#/c/946/
Comment 12 Wim Lewis 2018-11-29 08:21:27 UTC
For what it's worth, I'm still experiencing this problem with trojitá git-head (76151f1a, Oct 10 2018) on Ubuntu "bionic" 18.04. My qtwebkit packages are at 5.212.0; most of my other Qt packages are at 5.9.5-0ubuntu[something]:

$ dpkg-query -l | fgrep -i qt | fgrep -i webkit
ii  libqt5webkit5:amd64                           5.212.0~alpha2-7ubuntu1                     amd64        Web content engine library for Qt
ii  libqt5webkit5-dev:amd64                       5.212.0~alpha2-7ubuntu1                     amd64        Web content engine library for Qt - development files
ii  libqtwebkit4:amd64                            2.3.2-0ubuntu13                             amd64        Web content engine library for Qt
ii  python3-pyqt5.qtwebkit                        5.10.1+dfsg-1ubuntu2                        amd64        Python 3 bindings for Qt5's WebKit module


Both plaintext and HTML messages are displayed much narrower than they should be, but HTML messages seem to be only as narrow as the widest image in the message. Plain text messages are 1 or 2 characters wide.
Comment 13 Jan Kundrát 2018-12-05 20:27:52 UTC
(In reply to Wim Lewis from comment #12)
> For what it's worth, I'm still experiencing this problem with trojitá
> git-head (76151f1a, Oct 10 2018) on Ubuntu "bionic" 18.04. My qtwebkit
> packages are at 5.212.0; most of my other Qt packages are at
> 5.9.5-0ubuntu[something]:
> 
> $ dpkg-query -l | fgrep -i qt | fgrep -i webkit
> ii  libqt5webkit5:amd64                           5.212.0~alpha2-7ubuntu1   
> amd64        Web content engine library for Qt
> ii  libqt5webkit5-dev:amd64                       5.212.0~alpha2-7ubuntu1   
> amd64        Web content engine library for Qt - development files
> ii  libqtwebkit4:amd64                            2.3.2-0ubuntu13           
> amd64        Web content engine library for Qt
> ii  python3-pyqt5.qtwebkit                        5.10.1+dfsg-1ubuntu2      
> amd64        Python 3 bindings for Qt5's WebKit module
> 
> 
> Both plaintext and HTML messages are displayed much narrower than they
> should be, but HTML messages seem to be only as narrow as the widest image
> in the message. Plain text messages are 1 or 2 characters wide.

I don't see that package for 18.04 Ubuntu I'm afraid:

https://packages.ubuntu.com/search?suite=cosmic&section=all&arch=any&keywords=libqt5webkit5&searchon=names

Can you double-check that your qt webkit build contains the patches linked from https://github.com/annulen/webkit/issues/511#issuecomment-338685652 ?

Either way, this is something which got fixed in upstream, and I am not aware of any possible workaround on Trojita's side, sorry.
Comment 14 Christoph Feck 2019-08-07 22:18:20 UTC
*** Bug 410706 has been marked as a duplicate of this bug. ***