Bug 378453 - In latest git master- names of the filter mask (created through filter dialog) is set to "effects" instead of the mask type name
Summary: In latest git master- names of the filter mask (created through filter dialo...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (other bugs)
Version First Reported In: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-05 05:32 UTC by Raghavendra kamath
Modified: 2017-04-06 12:51 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Raghavendra kamath 2017-04-05 05:32:16 UTC
When a user clicks on the "create filter mask" button in any filter dialog, a filter mask gets added to the currently selected layer.

The name of this filter mask is set to generic "effects", it would be immensely helpful if the name would be something like " Hue/saturation Mask" etc depending on the type of effects that is added through mask.

To reproduce

1) Open krita built from git master 
2) Add a layer and select it and trigger a filter dialog e.g Ctrl + U and then press the "Create Filter Mask" Button

You'll notice that a filter mask is added with name "effects"
Comment 1 Halla Rempt 2017-04-06 12:51:18 UTC
Git commit 535164d609c77ec6a895272b7ac5a44bfee6f4e1 by Boudewijn Rempt.
Committed on 06/04/2017 at 12:51.
Pushed by rempt into branch 'krita/3.1'.

This is also finally uses the currentFilter field in the Private
class... It was never set anywhere.

M  +2    -0    libs/ui/dialogs/kis_dlg_filter.cpp

https://commits.kde.org/krita/535164d609c77ec6a895272b7ac5a44bfee6f4e1
Comment 2 Halla Rempt 2017-04-06 12:51:19 UTC
Git commit 1616c234749eb4f8b94188f96d0d70f52030c404 by Boudewijn Rempt.
Committed on 06/04/2017 at 12:51.
Pushed by rempt into branch 'master'.

This is also finally uses the currentFilter field in the Private
class... It was never set anywhere.

M  +2    -0    libs/ui/dialogs/kis_dlg_filter.cpp

https://commits.kde.org/krita/1616c234749eb4f8b94188f96d0d70f52030c404