Bug 378282 - Filter Layer/Artistic/Index Color's Color Picker cannot pick colors outside oh its own window.
Summary: Filter Layer/Artistic/Index Color's Color Picker cannot pick colors outside o...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filters (show other bugs)
Version: 3.1.2
Platform: Other macOS
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-30 15:25 UTC by burç tuncer
Modified: 2020-06-18 17:08 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screen capture of the bug (1.33 MB, image/gif)
2017-03-30 15:34 UTC, burç tuncer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description burç tuncer 2017-03-30 15:25:58 UTC
On OSX (I'm on El Capitan btw) Filter Layer/Artistic/Index Color's Color Picker cannot pick colors outside its own window. The picker cursor "+" switches back to the default "arrow" when hovering outside the color picker dialogue.

I can confirm this but is NOT PRESENT in the Windows build. Some window manager wrapper problem maybe?
Comment 1 burç tuncer 2017-03-30 15:34:10 UTC
Created attachment 104819 [details]
screen capture of the bug

here you can see as the cursor leaves the color picker dialogue, it reverts back to the default "arrow" cursor and cannot pick anything outside.
Comment 2 burç tuncer 2017-03-30 15:37:21 UTC
I downloaded an older version (3.0) and I can confirm that the bug is NOT PRESENT in this version. On this version, the color picker is OSX's default color picker and it works as intended. Maybe this is a problem with the new color picker?
Comment 3 Halla Rempt 2017-04-06 09:36:41 UTC
Yes, the default Qt color dialog was replaced with a color managed one. We then reimplemented Qt's default screen color picking in our own dialog. But because on OSX, Qt doesn't use its internal code, but the OSX color dialog, this also meant that on OSX we replaced the OS color dialog with our own dialog.
Comment 4 Halla Rempt 2017-04-06 10:00:05 UTC
Git commit e6f88a3a65332d21546231349e0c36323f0c289e by Boudewijn Rempt.
Committed on 06/04/2017 at 09:59.
Pushed by rempt into branch 'master'.

On OSX, the only way to pick screen colors is to use the native
color selector, applications cannot access other windows than
their own.

M  +19   -6    libs/ui/widgets/KoDualColorButton.cpp
M  +32   -5    libs/ui/widgets/kis_color_button.cpp

https://commits.kde.org/krita/e6f88a3a65332d21546231349e0c36323f0c289e
Comment 5 Halla Rempt 2017-04-06 10:01:15 UTC
Git commit 6b2dfb06a19d570df1318ef3d763714db53b1d4f by Boudewijn Rempt.
Committed on 06/04/2017 at 10:00.
Pushed by rempt into branch 'krita/3.1'.

On OSX, the only way to pick screen colors is to use the native
color selector, applications cannot access other windows than
their own.

M  +19   -6    libs/ui/widgets/KoDualColorButton.cpp
M  +32   -5    libs/ui/widgets/kis_color_button.cpp

https://commits.kde.org/krita/6b2dfb06a19d570df1318ef3d763714db53b1d4f
Comment 6 Yu-Hsuan Lai 2020-06-18 17:08:27 UTC
But Clip Studio Paint is able to pick color from other windows, even on MacOS?