Created attachment 104754 [details] File layer not updating after the file on the right was saved Steps: 1. Add a file layer 2. Modify the source of the file layer and save. The file layer updates. 3. Redo step 2. The file layer isn't updated anymore. I tried with different file types and the result is the same. It will only update if you close and reopen the document that contains the file layer. See the attached image.
I can reproduce the bug in the krita 3.2.1 appimage, running on debian testing.
Can confirm still happens on Windows 10 on ver.3.2
This is caused... by the backups, strangely enough. QFileSystemWatcher considers saving to the backup and then saving a new file to the old path the same as deleting the path. https://stackoverflow.com/questions/18300376/qt-qfilesystemwatcher-signal-filechanged-gets-emited-only-once
Git commit 829876d88b5fbdc1a79d235d11a459753a1fd81d by Wolthera van Hövell tot Westerflier. Committed on 12/09/2017 at 16:24. Pushed by woltherav into branch 'master'. Basically, this was caused by the backups. Krita handles backups by saying "ok, you, old file, rename to backup, and new file, you become the url of old file". This renaming is what signals QFileSystemWatcher, and because it is a rename, it removes it from the list of watched files. So what we do is that when we get our change in, we check if the file exists and is still being watched, and if so we readd it. M +4 -0 libs/ui/kis_safe_document_loader.cpp https://commits.kde.org/krita/829876d88b5fbdc1a79d235d11a459753a1fd81d
Git commit ce183f5050c5b66fe89b0818ede64d6e068ad6ad by Boudewijn Rempt, on behalf of Wolthera van Hövell tot Westerflier. Committed on 12/09/2017 at 16:55. Pushed by rempt into branch 'krita/3.3'. Basically, this was caused by the backups. Krita handles backups by saying "ok, you, old file, rename to backup, and new file, you become the url of old file". This renaming is what signals QFileSystemWatcher, and because it is a rename, it removes it from the list of watched files. So what we do is that when we get our change in, we check if the file exists and is still being watched, and if so we readd it. M +4 -0 libs/ui/kis_safe_document_loader.cpp https://commits.kde.org/krita/ce183f5050c5b66fe89b0818ede64d6e068ad6ad