Bug 378042 - Icons in Task Manager Dropdowns are too large, causing Dropdown to be clipped
Summary: Icons in Task Manager Dropdowns are too large, causing Dropdown to be clipped
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager (show other bugs)
Version: 5.8.6
Platform: openSUSE Linux
: NOR major
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-24 23:28 UTC by spacemant5010
Modified: 2017-08-15 11:39 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Task Manager Dropdown Incorrectly Clipped (111.53 KB, image/png)
2017-03-25 21:41 UTC, spacemant5010
Details

Note You need to log in before you can comment on or make changes to this bug.
Description spacemant5010 2017-03-24 23:28:38 UTC
I've assigned this to the "Task Manager" because I assume it's responsible for showing the list of icon/title "group" labels inside the panel and the dropdowns below those labels.  My observations:
* The icon size in the icon/title "group" labels in the panel itself are OK - they are small (16px or 22px).
* However, the icon size for each instance of the application in the dropdown that shows up when you click a "group" label is too large - perhaps 32px or 48px.  

If the icon size in the dropdown were the only/final problem, it would just be an annoyance, since the result would be fewer of each instance visible per dropdown.  However, it's actually causing the dropdown to be clipped and hiding instances of apps so they can't be accessed - at least I believe this is what's going on.  

My theory is that the code is calculating the dropdown height based on the font height * # of instances, but actually it won't hold that many instances because the huge icon size is forcing each instance line to take up more vertical real estate than the font height would predict.

Note: ***This is a NEW problem that started happening perhaps 1 month ago after an update.  When I originally installed 42.2 the dropdown icons had a small size and there was no clipping.***

Best case - fix it outright.  Workable solution - give me a way to change the icon size in the dropdowns.  I've searched the web and tried to do it, but I've only found methods for changing the icon size in the group labels in the panel - not the dropdown.  I've also tried many different skins with no joy.

System:
OpenSUSE 42.2 Leap x64 (Fully patched)
KDE Plasma Version: 5.8.6
KDE Framework Version: 5.26.0
Qt Version: 5.6.1
Kernel Version: 4.4.9-16 default
Comment 1 spacemant5010 2017-03-25 21:41:11 UTC
Created attachment 104732 [details]
Task Manager Dropdown Incorrectly Clipped
Comment 2 Eike Hein 2017-03-27 07:23:00 UTC
This was rewritten for 5.9 and is now scrollable.
Comment 3 spacemant5010 2017-03-31 18:45:51 UTC
I'm running OpenSUSE 42.2 which is an LTS release.  I won't get KDE 5.9.  I need this fixed in KDE 5.8 or I'm in a broken state forever.

As mentioned in the original bug report, this was working, and then got broken by an update to KDE.  So at a minimum, that update needs to be reverted.
Comment 4 Eike Hein 2017-03-31 19:00:21 UTC
We're considering backporting the dialog rewrite to the LTS branch (so both 5.8.x and 5.9.x maintenance releases).
Comment 5 Eike Hein 2017-04-03 14:07:44 UTC
Git commit 76034a4cd3b2ecd2d97802037ea6db0756651786 by Eike Hein.
Committed on 03/04/2017 at 14:06.
Pushed by hein into branch 'Plasma/5.8'.

Backport 5.9/Master's GroupDialog code to 5.8.

Summary:
This brings us to a common baseline on the three active branches
and addresses regressions on the 5.8 branch.

5.9's code added a scrollbar and improved keyboard nav.

Reviewers: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D5287

M  +107  -23   applets/taskmanager/package/contents/ui/GroupDialog.qml
M  +13   -2    applets/taskmanager/package/contents/ui/MouseHandler.qml
M  +7    -3    applets/taskmanager/package/contents/ui/Task.qml
M  +12   -0    applets/taskmanager/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/76034a4cd3b2ecd2d97802037ea6db0756651786
Comment 6 Freddy Rietdijk 2017-05-28 13:43:01 UTC
By backporting this fix there's now an implicit dependency on Qt 5.7 in 5.8.7.
https://bugs.kde.org/show_bug.cgi?id=380240
Comment 7 Eike Hein 2017-05-29 09:58:25 UTC
We're working on fixing this currently.
Comment 8 spacemant5010 2017-07-04 05:21:57 UTC
I was able to use this in OpenSUSE 42.2 by adding the 5.8.7 LTS KDE Repository manually, after the OpenSUSE team refused to take the update.

I am seeing one slight issue with the scrolling fix.  There appears to be a slight  "bounce" when you reach the top or bottom - the list of task instances will scroll past the end and the "bounce" back.  Is there any way to eliminate that?

Thanks.

Also, is there any way to convince the OpenSUSE team to take this update in 42.2 (which is using the 5.8.7 LTS stream)?  It's inconvenient to have a separate repository in the dependencies because I have to separately update it.
Comment 9 Eike Hein 2017-08-15 11:39:10 UTC
Git commit 49fb504149e3ea3690616510ee313d33c7233d53 by Eike Hein.
Committed on 15/08/2017 at 11:25.
Pushed by hein into branch 'Plasma/5.8'.

Disable bouncy scrolling.

Summary:
Matches other Plasma scrollable lists (e.g. Kicker's).

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D7322

M  +2    -0    applets/taskmanager/package/contents/ui/GroupDialog.qml

https://commits.kde.org/plasma-desktop/49fb504149e3ea3690616510ee313d33c7233d53