Bug 377944 - [PATCH] Mixed up color variable and wrong indexing in apply-stylesheet.sh
Summary: [PATCH] Mixed up color variable and wrong indexing in apply-stylesheet.sh
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: libplasma (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-22 17:49 UTC by Andreas
Modified: 2017-03-24 12:46 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
patch, fixes the issue (126 bytes, patch)
2017-03-22 17:49 UTC, Andreas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas 2017-03-22 17:49:43 UTC
Created attachment 104690 [details]
patch, fixes the issue

I found this in /plasma-framework/src/tools/apply-stylesheet.sh (a helper script for creating plasma themes)

Steps to reproduce:
1) use the script to make a plasma theme color-scheme-aware

Result:
1) the button hover color is not assigned as expected
2) all but the first 5 color variables are not assigned at all

Problem:
1) under --ButtonHoverFrom) it assigns buttonBackgroundFrom (again) instead of buttonHoverFrom

2) the loop should obviously go over the entire array of color variables, but is hardcoded to 5 iterations, i changed it to the array lenght

see patch, attached
Comment 1 Andreas 2017-03-22 18:18:10 UTC
sorry, i put this in the wrong section

i'm not sure where to put this exactly, i'm fairly certain it belongs somewhere under frameworks-plasma, but not sure which subsection. also, i'm not sure which version i have to pick here, it's from the git master.

sorry again, i am new to this, if i made an error please reassign it again
Comment 2 Marco Martin 2017-03-24 12:46:27 UTC
Git commit 874a7e39b92285e2edeb74c14c05fbf02efe4934 by Marco Martin.
Committed on 24/03/2017 at 12:46.
Pushed by mart into branch 'master'.

fix typo, iterate all colors available

patch by andi.berger@yandex.com

M  +2    -2    src/tools/apply-stylesheet.sh

https://commits.kde.org/plasma-framework/874a7e39b92285e2edeb74c14c05fbf02efe4934