Bug 377672 - Revision 85957712044d7a91d3ee4eec4012c333cd7fe70e breaks finding qmake on Fedora with qt3-devel installed
Summary: Revision 85957712044d7a91d3ee4eec4012c333cd7fe70e breaks finding qmake on Fed...
Status: REPORTED
Alias: None
Product: kdevelop
Classification: Applications
Component: Build tools: QMake (other bugs)
Version First Reported In: 5.0.4
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-16 02:56 UTC by Kevin Kofler
Modified: 2022-11-18 09:43 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Kofler 2017-03-16 02:56:50 UTC
This revision:
https://cgit.kde.org/kdevelop.git/commit/?id=85957712044d7a91d3ee4eec4012c333cd7fe70e
is the wrong thing to do on Fedora. The unsuffixed qmake in the PATH, if any, is the Qt 3 version from qt3-devel. The proper order to search for is qmake-qt5, qmake-qt4, qmake.
Comment 1 Milian Wolff 2017-03-18 16:24:58 UTC
there's no way we can make it right for all platforms, I'm afraid. When you install a custom Qt into /opt and put it into your PATH, it's qmake will be the right one. So I think keeping the order we have is correct. If at all we could try to run the qmake we found and see if it's at least version 4 and if not then continue.
Comment 2 Kevin Kofler 2017-03-18 16:28:37 UTC
> I'm afraid. When you install a custom Qt into /opt and put it into your PATH,
> it's qmake will be the right one.

Who says that the user doesn't want to use the distro Qt instead? IMHO, the distro Qt is always the right one if something else was not explicitly requested. It is the one most likely to just work.

> If at all we could try to run the qmake we found and see if it's at least
> version 4 and if not then continue.

For the record, that's what CMake does.
Comment 3 Milian Wolff 2017-03-18 22:05:14 UTC
Doing what cmake does sounds fine to me.

And to your claim that "the distro Qt is always the right one" - that is completely wrong. In my work for KDAB I see tons of Linux based Qt projects, and only the minority of those rely on the distro Qt. Most instead use a specific Qt version built into /opt or elsewhere. Especially for embedded projects, people often even put the SDK's qmake into their PATH.
Comment 4 Justin Zobel 2022-11-03 01:39:53 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 5 Bug Janitor Service 2022-11-18 05:15:52 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Kevin Kofler 2022-11-18 09:42:01 UTC
Updated link to the offending commit: https://invent.kde.org/kdevelop/kdevelop/-/commit/85957712044d7a91d3ee4eec4012c333cd7fe70e

The bad code is now in a new location:
https://invent.kde.org/kdevelop/kdevelop/-/blob/master/plugins/qmakemanager/qmakeconfig.cpp
but still using the same wrong algorithm to find qmake.
Comment 7 Kevin Kofler 2022-11-18 09:43:05 UTC
And plugins/qthelp/qthelpqtdoc.cpp now has its own code to find qmake, with the same bug.