Bug 377652 - Some Kicker icons should be highlighted while hovering cursor over them (like in Kickoff)
Summary: Some Kicker icons should be highlighted while hovering cursor over them (like...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Menu (Kicker) (show other bugs)
Version: 5.9.3
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-15 16:21 UTC by Pekka Helenius
Modified: 2017-03-24 14:05 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pekka Helenius 2017-03-15 16:21:32 UTC
Not tehcnically a bug but more like strong wish:

Kicker main icon (panel icon) should be hightlighted while hovering cursor over it. Additionally, I noticed that icons in the favorites list also miss hightlighting. This is not the case in Kickoff launcher.

Highlighting relevant icons improves the overall feeling of responsiveness of the system. Right now, the whole Kicker Application Menu (& especially the mentioned icons) feels just discrete & clumsy and somehow unfinished, not so responsive. Though *technically*, every feature works as intended.

If this highlighting feature is discussed and rejected before, at least make it an option in the Kicker launcher configuration menu ("Application Menu Settings") so everyone can individually decide whether to enable the highlighting or not.

I remember that lack of highlighting was already an issue in Plasma 4, and was the only reason I've never really used (Homerun) Kicker as my app launcher. However, I really love its simplicity and prefer the layout over the default Kickoff launcher.
Comment 1 Kai Uwe Broulik 2017-03-15 19:24:18 UTC
The icon in the panel does highlight when you hover it, it might be a bit hard to see due to the icon being all black. As for the highlight in favorites strip, I agree that they should highlight on hover and I'll prepare a patch to fix this.
Comment 2 Pekka Helenius 2017-03-15 19:38:40 UTC
Okay, thank you for the reply!

I've set a custom SVG image as the main launcher icon (Arch Linux Logo with blue blackground). I've also used the same image with Kickoff and the difference between a normal and highlighted launcher icon is very, very visible.
Comment 3 Kai Uwe Broulik 2017-03-15 19:40:10 UTC
Ok, the difference why you won't get a highlight then might be that in Kickoff you go through the icon dialog to choose an icon which is displayed using Plasma's IconItem whereas Kicker lets you choose a custom path directly and then uses a regular Image item (as back when this was implemented IconItem didn't support non-square icons).
Comment 4 Kai Uwe Broulik 2017-03-20 11:45:03 UTC
Git commit db297ab5acb93f88c238778e8682effe3032bf4f by Kai Uwe Broulik.
Committed on 20/03/2017 at 11:42.
Pushed by broulik into branch 'Plasma/5.8'.

[Kicker] Fix highlighting favorites

ToolTipArea steals mouse events from the MouseEventListener.

Differential Revision: https://phabricator.kde.org/D5064

M  +1    -1    applets/kicker/package/contents/ui/SideBarItem.qml

https://commits.kde.org/plasma-desktop/db297ab5acb93f88c238778e8682effe3032bf4f
Comment 5 Pekka Helenius 2017-03-21 08:51:21 UTC
Thanks Kai! Favorites menu items work now. +1

Launcher icon still lacks visible highlighting. I consider the issue partially fixed (but not completely).

P.S. Thanks for the explanation of why the launcher icon may miss visible highlighting.
Comment 6 Eike Hein 2017-03-21 12:08:30 UTC
I'll look into the other half of the ticket soon.
Comment 7 Eike Hein 2017-03-22 20:53:45 UTC
This needs some further work in IconItem to allow us to do applet size hints similar to Image does - I've got a patch coming up, and one to Kicker to port it to IconItem.
Comment 8 Pekka Helenius 2017-03-23 09:49:37 UTC
Thanks, Eike!

Background story for this "bug" issue is as follows (just my thoughts): 

As the current KDE version offers various launcher alternatives, I think making similar functions such as highlighting same icons for these launcher (Kickoff, Kicker etc.) would improve the desktop experience & make the experience overall more coherent/united for KDE end-users. If one launcher does highlight critical icons but the other one does not, well, that's somehow broken desktop experience.

Anyway. I'm happy you're working on this issue, I look forward to it being resolved. Take your time writing the necessary changes.
Comment 9 Eike Hein 2017-03-23 21:29:04 UTC
Patches to plasma-framework and Kicker under review:
https://phabricator.kde.org/D5160
https://phabricator.kde.org/D5162
Comment 10 Pekka Helenius 2017-03-23 22:29:46 UTC
Just tested the patches. Highlighting works as expected with them. Thank you so much for your trouble and fast response! Finally after these years Kicker can be used as a perfect replacement for Kickoff without suffering from any of these little annoyances. Hopefully your patches will be implemented soon.

I consider the issue as fixed.

Thank you again!
Comment 11 Eike Hein 2017-03-24 14:04:12 UTC
Git commit b80a8aa51456804e25385d6386df8afac1d762cb by Eike Hein.
Committed on 24/03/2017 at 12:41.
Pushed by hein into branch 'master'.

Port custom image mode to IconItem.

Summary:
Simplifies compact representation to always using IconItem, now
that IconItem supports displaying non-square image sources.

Fixes missing hover highlight effect for custom image launcher
buttons.

Depends on D5160 in plasma-framework to work correctly, enabling
it to learn image source aspect ratio from the IconItem's implicit
size.

A good follow-up would be aligning Kickoff and Kicker compact
representation sizing behavior and config UI now.

Reviewers: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D5162

M  +33   -63   applets/kicker/package/contents/ui/CompactRepresentation.qml

https://commits.kde.org/plasma-desktop/b80a8aa51456804e25385d6386df8afac1d762cb
Comment 12 Eike Hein 2017-03-24 14:05:12 UTC
@Fincer: Thx!