Bug 377638 - Database directory ignoring hidden and unnecessarily in migration-dialogue [patch]
Summary: Database directory ignoring hidden and unnecessarily in migration-dialogue [p...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Setup-Database (show other bugs)
Version: 5.5.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-15 11:45 UTC by Simon
Modified: 2017-08-09 20:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.6.0
Sentry Crash Report:


Attachments
Put ignored directories in its own tab (16.25 KB, patch)
2017-03-15 11:45 UTC, Simon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon 2017-03-15 11:45:30 UTC
Created attachment 104584 [details]
Put ignored directories in its own tab

Problem:
The new functionality to ignore directories is hidden (as in you need to scroll down a lot) as the database configuration widget is now very long.
Also this options do not really matter for database migration, but come up there as well now. This dialogue is already pretty text heavy, this just adds additional needless complexity.

Solution:
Take ignoring directories out of DatabaseSettingsWidget and add it to SetupDatabase as a new tab.
Comment 1 caulier.gilles 2017-03-15 18:30:06 UTC
The idea sound fine for me.

I do not see any problem in patch (not tested).

Gilles
Comment 2 Simon 2017-03-18 15:48:03 UTC
@Gilles did you get a chance to test? It worked fine for me.
Comment 3 caulier.gilles 2017-03-18 17:07:48 UTC
yes, i will do it...
Comment 4 caulier.gilles 2017-03-19 08:54:31 UTC
PAtch work fine for me...

Gilles
Comment 5 Simon 2017-03-19 13:05:03 UTC
Git commit fe004359a3d73a69c8958a532e88f8a6c9355f5a by Simon Frei.
Committed on 19/03/2017 at 13:02.
Pushed by sfrei into branch 'master'.

Move ignoring directories to its own tab in configuration
FIXED-IN: 5.6.0

M  +2    -1    NEWS
M  +0    -72   libs/database/utils/dbsettingswidget.cpp
M  +0    -4    libs/database/utils/dbsettingswidget.h
M  +124  -39   utilities/setup/setupdatabase.cpp
M  +9    -0    utilities/setup/setupdatabase.h

https://commits.kde.org/digikam/fe004359a3d73a69c8958a532e88f8a6c9355f5a