Bug 377491 - Artifacts when flattening animated layer with transform mask
Summary: Artifacts when flattening animated layer with transform mask
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: 3.1.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-11 11:15 UTC by z-uo
Modified: 2021-03-02 19:15 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
an exemple of the result (25.45 KB, image/png)
2017-03-11 11:15 UTC, z-uo
Details
animation before transformation (454.38 KB, application/x-krita)
2017-03-14 09:48 UTC, z-uo
Details
animation after transformation with part of some frames copied on other frames (467.48 KB, application/x-krita)
2017-03-14 09:49 UTC, z-uo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description z-uo 2017-03-11 11:15:34 UTC
Created attachment 104504 [details]
an exemple of the result

the steps:
start an animation with 5 frames
Draw something on each frame (tiny things and big things in different places of the canvas)
add a transform layer to the animation layer
reduce the size
flatten the layer

the result is some part of drawings in bigs frames are copied in tiny frames
Comment 1 Halla Rempt 2017-03-14 09:34:59 UTC
Hm, this is logical, I guess... I see that all frames get the transform mask applied. I'm not sure where this happens, though, and I don't see artefacts.
Comment 2 Halla Rempt 2017-03-14 09:44:25 UTC
Note:

10:40:52 < Animtim> if it's about the transform mask being applied on every frame, that is by design and not a bug (very useful to move around a complete animation..)

But then we still have the issue that the transform mask is only applied to the current frame on creation. I wonder whether it gets applied to all frames on saving/loading.
Comment 3 z-uo 2017-03-14 09:48:28 UTC
Created attachment 104552 [details]
animation before transformation
Comment 4 z-uo 2017-03-14 09:49:23 UTC
Created attachment 104553 [details]
animation after transformation with part of some frames copied on other frames
Comment 5 z-uo 2017-03-14 09:51:01 UTC
Maybe my exemple wasn't clear, watch the two new attachments to understand the problem.

(and the transform mask is very usefull with animation, I agree)
Comment 6 joupent 2018-05-18 13:54:51 UTC
Clarification: parts of the currently active frame remain in flattened versions of any frames with smaller bounds
Comment 7 Eoin O'Neill 2021-02-12 02:00:47 UTC
Git commit a8c1d0263847f2b921def037033ff1d550e343fa by Eoin O'Neill.
Committed on 12/02/2021 at 01:55.
Pushed by eoinoneill into branch 'master'.

Attempt to fix artifacts regarding transform masks and animated layer combinations.

M  +5    -5    libs/image/kis_layer_utils.cpp
M  +13   -0    libs/image/kis_transform_mask.cpp

https://invent.kde.org/graphics/krita/commit/a8c1d0263847f2b921def037033ff1d550e343fa