Bug 377447 - Fails to build on windows missing winsock library
Summary: Fails to build on windows missing winsock library
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: 1.6
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-10 08:27 UTC by brkopac
Modified: 2017-03-29 12:36 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/konversation/76bb64da6265554ec01ba80a9dbb5833c1165e37
Version Fixed In: 1.7.0
Sentry Crash Report:

Attachments
log from craft (58.44 KB, application/octet-stream)
2017-03-10 08:27 UTC, brkopac 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description brkopac 2017-03-10 08:27:50 UTC 
Created attachment 104487 [details]
log from craft

konversation fails to link on windows due to it failing to link winsock. I've attached the output log from craft.
Comment 1 Eike Hein 2017-03-29 12:01:37 UTC 
Does it work with the 1.7 or master branches? There have been Windows build fixes since 1.6.
Comment 2 Eike Hein 2017-03-29 12:14:58 UTC 
Our Windows guy could reproduce, we might have a fix coming.
Comment 3 Eike Hein 2017-03-29 12:27:21 UTC 
Patch under review: https://phabricator.kde.org/D5237
Comment 4 Kevin Funk 2017-03-29 12:36:06 UTC 
Git commit 76bb64da6265554ec01ba80a9dbb5833c1165e37 by Kevin Funk.
Committed on 29/03/2017 at 12:35.
Pushed by kfunk into branch '1.7'.

Fix compilation under Windows

Summary:
Under Visual Studio, I actually don't need to link in ws2_32 myself, it
works as-is. Better do it explicitly, though, since we do use symbols
from ws2_32 (ntohl, etc.).
FIXED-IN: 1.7.0

Differential Revision: https://phabricator.kde.org/D5237

M  +3    -0    src/CMakeLists.txt
M  +8    -0    src/dcc/transferrecv.cpp
M  +8    -0    src/dcc/transfersend.cpp

https://commits.kde.org/konversation/76bb64da6265554ec01ba80a9dbb5833c1165e37