Notifications 'end of short/long breaks' notify even when they are not needed. Tiny breaks are currently set to 20 seconds. I set a sound to end of short break, but it was irritating since it played the sound in every 20 seconds. I think that what the 'when the short timer has been reset' is for, and it does the job well. End of short/long break should notify only when there was a break. I think at this very moment the timers reset and end of breaks are do the very same.
> I set a sound to end of short break, but it was irritating since it played the sound in every 20 seconds. When do you think it should play?
I think they do what 'When timers have been reset' do right now. Actually, they do exactly the same thing. If I touch neither my mouse nor my keyboard for several seconds/minutes they play the notification sounds. That's okay for 'timers have been reset'. However, In my opinion 'End of short break' and 'End of a long break' should only notify me when the break is over. Without actual breaks it shouldn't play any sound. Let say you set the tiny breaks to 20 seconds in every 10 minutes. You probably don't watch the screen during the break (I think that's the purpose of these breaks), you might turn your head away and the sound can signal you that the break is over. On the other hand it is very irritating if you watch a movie and rsibreak constantly plays music. First the tiny break sound then the normal break sound. I occasionally adjust the sound level so rsibreak plays the sounds over and over and needless to say "timer reset" options do the very same in case someone wants this kind of behavior.
Thanks for the update, changing status.
Git commit 0cdbdf5dd11b2acd50ef5addfc62d7734c668a02 by Albert Astals Cid. Committed on 17/04/2017 at 21:18. Pushed by aacid into branch 'master'. Only trigger end of break when we're actually on a break If we are resetting the timer because of user inactivity do not notify break ending since that gets notified as "timer reset" M +24 -16 src/rsitimer.cpp M +2 -2 src/rsitimer.h https://commits.kde.org/rsibreak/0cdbdf5dd11b2acd50ef5addfc62d7734c668a02
(In reply to Albert Astals Cid from comment #4) > Git commit 0cdbdf5dd11b2acd50ef5addfc62d7734c668a02 by Albert Astals Cid. > Committed on 17/04/2017 at 21:18. > Pushed by aacid into branch 'master'. > > Only trigger end of break when we're actually on a break > > If we are resetting the timer because of user inactivity do not notify > break ending since that gets notified as "timer reset" > > M +24 -16 src/rsitimer.cpp > M +2 -2 src/rsitimer.h > > https://commits.kde.org/rsibreak/0cdbdf5dd11b2acd50ef5addfc62d7734c668a02 You did a great job! Thank you!