Bug 377406 - Fails to build on windows with linker error
Summary: Fails to build on windows with linker error
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kdoctools
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR critical
Target Milestone: ---
Assignee: Documentation Editorial Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-09 02:15 UTC by brkopac
Modified: 2017-03-09 22:37 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
log from craft (18.29 KB, application/octet-stream)
2017-03-09 02:15 UTC, brkopac
Details
Do not link the same functions both directly and through the library meinproc5 (766 bytes, patch)
2017-03-09 08:19 UTC, Luigi Toscano
Details

Note You need to log in before you can comment on or make changes to this bug.
Description brkopac 2017-03-09 02:15:49 UTC
Created attachment 104466 [details]
log from craft

kdoctools fails to build using:

craft kdoctools > log 2>&1
Comment 1 Luigi Toscano 2017-03-09 07:58:52 UTC
(In reply to brkopac from comment #0)
> Created attachment 104466 [details]
> log from craft
> 
> kdoctools fails to build using:
> 
> craft kdoctools > log 2>&1

There was a change in KDocTools 5.32 (it finally provides a dynamic library instead of a static one), and I informed the packagers. Unfortunately I can't do anything about it (no environment), so I can only rely on windows packagers.
Comment 2 Luigi Toscano 2017-03-09 08:19:45 UTC
Created attachment 104468 [details]
Do not link the same functions both directly and through the library meinproc5

Unless... can you please try the attached patch? It still compiles locally (tested on Debian), so it may work, if I read the error correctly.
Comment 3 Luigi Toscano 2017-03-09 22:31:42 UTC
Git commit d2186e6786b3f717080a7b4b2264787a40f8d4a0 by Luigi Toscano.
Committed on 09/03/2017 at 21:11.
Pushed by ltoscano into branch 'master'.

meinproc5: link to the files, not to the library

The code worked with the GCC stack on GNU/Linux, but not with MSVC 19.0
(2015).

Reviewed-by: Kevin Funk <kfunk@kde.org>

M  +1    -1    src/CMakeLists.txt

https://commits.kde.org/kdoctools/d2186e6786b3f717080a7b4b2264787a40f8d4a0
Comment 4 brkopac 2017-03-09 22:37:52 UTC
I can confirm this has been fixed. My craft is continuing its build. Thanks very much!