Bug 377392 - Select Folder on Going up (Feature Request)
Summary: Select Folder on Going up (Feature Request)
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: icons mode (show other bugs)
Version: 16.12.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-08 20:00 UTC by Tsu Jan
Modified: 2017-09-21 13:55 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tsu Jan 2017-03-08 20:00:19 UTC
It would be nice if Dolphin selected and scrolled to the folder from inside which the user has come up. Currently, when a folder is among many other ones inside a parent folder and the user goes up from inside it, Dolphin shows the start of the parent folder, so that the user can't know from where he/she has come there. Imagine an occasion, when the user wants to get out a older temporarily and go into another folder not far from it quickly. At the present time, that isn't possible visually -- the user should know the name of the second folder and type it in the filterbar.

This feature exists in most GTK file managers and also in pcmanfm-qt.

I took a look at Dolphin's code and couldn't find the needed tools to implement this behavior but I'm not familiar with the code yet. Can this be implemented in Dolphin or should some other part of KDE be patched?
Comment 1 Tsu Jan 2017-03-08 23:22:00 UTC
Never mind! I found an easy way to add the feature in question; will attach a patch after some tests.
Comment 2 Tsu Jan 2017-03-10 04:43:27 UTC
Added a patch here: https://git.reviewboard.kde.org/r/130002/diff/1/
Comment 3 Nate Graham 2017-09-04 04:39:58 UTC
Thanks so much for the patch, Tsu! Unfortunately, you caught us during a transitional time; reviewboard was being deprecated and your patch got missed. Can you re-upload it to to KDE's Phabricator instance?

http://phabricator.kde.org/

Please add "Dolphin" and "KDE Applications" as group reviewers. I will make sure the patch gets noticed.
Comment 4 Tsu Jan 2017-09-17 15:22:17 UTC
If only KDE was developed on GtiHub... Sorry, but the current situation doesn't encourage any contribution. Believe me, KDE needs a lot of contribution.
Comment 5 Nate Graham 2017-09-19 03:56:08 UTC
Creating a Phabricator account only needs to happen once, then you can use it forever. And there are a lot of advantages to Phabricator over Github. Try it, you'll like it! :) It would be a shame to let this patch to fall through the cracks.
Comment 6 Tsu Jan 2017-09-19 09:16:01 UTC
This isn't about advertising: I know for sure that GitHub is very practical, makes the contribution easy and doesn't waste anyone's time.

In comparison, I started to try phabricator with Enlightenment but it wasn't promising. I also wanted to try it with KDE months ago; it was an *obstacle*. Add to this the limited free time each of us may have.

KDE devs should have their reasons for not using github for active development, while many devs have their reasons to prefer it. These are facts without judgment. I don't participate in lengthy discussions about reasons.
Comment 7 Nate Graham 2017-09-20 00:05:24 UTC
I also don't participate in those kinds of lengthy discussions. I just grit my teeth and do it. ;) Again, it would be a shame to let this patch die. If you don't want to use KDE's Phabricator, are you willing to let me take over the patch?
Comment 8 Tsu Jan 2017-09-20 09:20:07 UTC
> are you willing to let me take over the patch?

Oh, that would be very kind of you! Yes, please! I haven't touched the patch for a long time; it may need to be updated. As far as I remember, at that time, some changes in Dolphin made the job very easy; just a few changes was enough for this functionality to be implemented.

Thanks for your attention!
Comment 9 Nate Graham 2017-09-21 13:17:27 UTC
Submitted the patch for you: https://phabricator.kde.org/D7914
Comment 10 Tsu Jan 2017-09-21 13:39:07 UTC
Thank you very much! Sorry that I wasn't able to do it!

IMHO, this is one the 2 "important" problems of Dolphin -- none of which is very important -- the other one being the random 1-s delay at startup.

If I find enough free time, I'll look into the second issue -- this time on phabricator.
Comment 11 Emmanuel Pescosta 2017-09-21 13:45:35 UTC
Git commit 3749b5552729b434655ddc950b120bb14fe888c7 by Emmanuel Pescosta, on behalf of Gregor Mi.
Committed on 21/09/2017 at 13:41.
Pushed by emmanuelp into branch 'master'.

Select child folder when navigating to a parent folder

Whenever the dolphin view is initialized to show the contents of a new URL
(e.g. "/home/x/test") it will be checked if the new URL is a parent of the
previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the check is
successful, then the common child (in this example: "/home/x/test/documents/")
folder item will be selected and scrolled into view.

REVIEW: 123253
Related: bug 335616

M  +1    -1    CMakeLists.txt
M  +11   -0    src/dolphinviewcontainer.cpp
M  +5    -0    src/dolphinviewcontainer.h

https://commits.kde.org/dolphin/3749b5552729b434655ddc950b120bb14fe888c7
Comment 12 Tsu Jan 2017-09-21 13:55:41 UTC
A very different method. Anyhow, it's great that Dolphin has it :)