Bug 377387 - merging animation layers should require a confirmation popup (merge layers / merge frames)
Summary: merging animation layers should require a confirmation popup (merge layers / ...
Status: CONFIRMED
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: 3.1.2
Platform: Other Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-08 15:18 UTC by gordie.lachance+dev
Modified: 2022-12-29 23:07 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gordie.lachance+dev 2017-03-08 15:18:18 UTC
Hi !

When merging animation layers; there should be a popup that would allow us to choose between 'merge layers' 'merge frames'.

1 / This would be really useful (we don't always want to have all our keyframes merged with the layer)
2 / Having a confirmation popup before the merge would avoid bad surprises - the undo history cannot handle the unmerge when there is a lot of keyframe.  

For the little story, I just got a nasty, nasty little trick here :
I wanted to do undo (CTRL+Z) but did 'merge layers' instead (CTRL+E); those two keys are side to side on AZERTY keyboard.
That kind of stuff could happen frequently.

It's not a problem when it's a single image since you can undo the action.
But here, in my case, with 50+ frames, Krita wasn't able to undo and I hadn't saved my file in a while, so... kind of annoying.

Thanks
Comment 1 Tiar 2020-04-03 10:57:00 UTC
Maybe just changing a shortcut for merging will fix it for you?

Also what is this other option, "merging frames"? How should it work?
Comment 2 gordie.lachance+dev 2020-04-09 09:48:58 UTC
not a shortcut problem, but a "safety" problem: if merging layers cannot be undone, it's important to have a confirmation popup before doing it.

to answer your question, merging frame would merge the frames of layers at a specific time (and only those frames) while merging layers would merge every frame of those layers.
Comment 3 Tiar 2020-04-09 11:02:15 UTC
The purpose of the shortcut is to do something quickly, a popup would defeat that purpose. People usually use this shortcut in their workflow multiple times, there are even people who make a new layer, draw a stroke, erase parts of it and then merge to the 'main' layer. Also we in general try to avoid popups as much as possible, since they are often distracting.

If you have an issue with accidentaly merging layers, you should just remove the shortcut or make it longer etc. to make sure it won't happen again.

The merging frames thing is interesting, but it would be a new action, most probably. 

Note for someone implementing, make sure it work correctly when on the current time slot the result layer (on the bottom) or one of the to-merge layers don't have a keyframe exactly in that time slot, but in some previous timeslots. Especially if those keyframes are semi-transparent.