Bug 377332 - Placeholder face icon is not themed
Summary: Placeholder face icon is not themed
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) widget (show other bugs)
Version: master
Platform: openSUSE Linux
: NOR minor
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-07 12:46 UTC by Fabian Vogt
Modified: 2019-06-16 22:42 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Vogt 2017-03-07 12:46:59 UTC
The workaround for bug 370362 (https://cgit.kde.org/plasma-desktop.git/commit/?id=52ba0122ebeb6aa21d23936d0fbef20f7d9f208f) not only uses an icon that does not fit the plasma theme now, it also does not use the same theme as sddm anymore.
Comment 1 David Edmundson 2017-03-07 14:16:06 UTC
It's a symptom of the fact that we have 2 icon themes (plasma and non plasma) with icons looking different where we want them to look the same. 

I don't think my thing was a workaround or wrong but maybe in the wrong place. I should have just deleted the plasma icon.
Comment 2 Fabian Vogt 2017-03-07 14:17:50 UTC
(In reply to David Edmundson from comment #1)
> It's a symptom of the fact that we have 2 icon themes (plasma and non
> plasma) with icons looking different where we want them to look the same. 
> 
> I don't think my thing was a workaround or wrong but maybe in the wrong
> place.

IMO it should be fixed in kde-user-manager instead to use the themed icon.

> I should have just deleted the plasma icon.

No, please not. The non-plasma icon really does not fit to breeze dark or breeze.
Comment 3 Alexander Mentyu 2017-08-28 08:18:39 UTC
I noticed that currently there are three different icons - in Kickoff, Login Screen (Breeze SDDM theme) and in Leave dialog. Avatar icon in Leave dialog looks more theme neutral for me and can be a candidate for using it system-wide.

Distribution: KDE neon Developer Edition Unstable Branches
KDE Plasma Version: 5.10.90
KDE Frameworks Version: 5.37.0
Qt Version: 5.9.1
Kernel Version: 4.10.0-32-generic