Due to a recent commit in master branch (https://cgit.kde.org/krita.git/commit/?id=4763f5e524c0cc08f38dae4b1a89d28a2649a985) . Converting from 16 bit integer (g10) profile or 8 bit integer g10 profile to 8 bit integer trc profile is broken. The resulting image is darker and wrong. To reproduce 1) Switch to master branch and compile krita 2) Open new document with 16 bit g10 or 8 bit integer g10 integer color profile 3) add some color dabs or gradients 4) Now change the color profile by going to convert image color space in image menu 5) choose 8 bit ( it automatically selects sRGB trc profile) dont check any option and press ok Expected result - image after color conversion shouldn't have huge difference in value or brightness Actual Result - Image after conversion is darker than what it used to produce earlier. Let me know if you need any more details. P.S. by g10 color profile i mean the color profiles ending with g10 in name
I guess we'd best revert that commit then. The scripting branch has a script that also provides the functionality.
I'll revert the commit then On 06.03.2017 12:18, Boudewijn Rempt wrote: > https://bugs.kde.org/show_bug.cgi?id=377267 > > --- Comment #1 from Boudewijn Rempt <boud@valdyas.org> --- > I guess we'd best revert that commit then. The scripting branch has a script > that > also provides the functionality. >
Git commit 1a35c0b0ef0a079a5d99fa4d1fa89fd299d261ee by Dmitry Kazakov. Committed on 06/03/2017 at 10:36. Pushed by dkazakov into branch 'master'. Revert "Proper change of color space and profile for image through "Image properties" dialog" This reverts commit 4763f5e524c0cc08f38dae4b1a89d28a2649a985. This commit breaks usual conversion of color spaces. See bug: https://bugs.kde.org/show_bug.cgi?id=377267 Ref D4328 M +0 -1 libs/image/commands/kis_image_set_projection_color_space_command.cpp M +0 -1 libs/image/kis_image.cc https://commits.kde.org/krita/1a35c0b0ef0a079a5d99fa4d1fa89fd299d261ee