Bug 377208 - "Invert scroll direction" controls "Tap-and-drag lock" setting in Touchpad settings (on Wayland)
Summary: "Invert scroll direction" controls "Tap-and-drag lock" setting in Touchpad se...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_touchpad (show other bugs)
Version: 5.17.5
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-04 16:16 UTC by Sascha Zenglein
Modified: 2020-01-22 21:35 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshots that describe the bug (448.65 KB, application/gzip)
2017-03-04 16:16 UTC, Sascha Zenglein
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Zenglein 2017-03-04 16:16:28 UTC
Created attachment 104367 [details]
Screenshots that describe the bug

Title says it all. When trying to toggle natural scrolling the "Apply" button behaves strangely and the tap and drag lock setting is changed when you can click apply.

I attached a few screenshots to show the behavior and visualize how to reproduce.

First is the original state. Then I toggle the scroll direction and apply. Result is that scroll direction gets unchecked and drag lock gets checked.

Next, when trying to toggle it again the "Apply" button stays grey. After unchecking it the same behavior as described above shows with turning off the setting.
Comment 1 Sascha Zenglein 2017-03-04 17:04:25 UTC
I checked the touchpad kcm and found this in main.qml:

>Controls.CheckBox {
>    id: naturalScroll
>    text: i18n("Invert scroll direction")
>
>    function load() {
>        enabled = touchpad.supportsNaturalScroll && !scrollmethod.isNoScroll
>        checked = enabled && touchpad.naturalScroll
>    }
>
>    onCheckedChanged: {
>        if (enabled && !root.loading) {
>            touchpad.tapDragLock = checked
>            root.changeSignal()
>        }
>    }
>
>    ToolTip {
>        text: i18n("Touchscreen like scrolling.")
>    }
>}

especially this line
> touchpad.tapDragLock = checked

looks suspicious.
Comment 2 Rajeesh K V 2017-03-11 04:28:10 UTC
Adding Roman to CC. @subdiff any ideas?
Comment 3 Szymon Łągiewka 2017-06-03 11:36:07 UTC
Still happening on Plasma 5.10 (Qt 5.8.0 in my system).
Comment 4 Roman Gilg 2017-06-06 10:08:39 UTC
Sorry, I just now noticed this bug report thanks to Szymon's comment.

Yea, seems to be a simple copy and paste error. Sascha also already found the right line back in march. Sascha, since you found it, do you want to create a Diff on https://phabricator.kde.org/ for it? I'll then accept it and push it for you, if you don't (yet) have commit rights.
Comment 5 Sascha Zenglein 2017-06-07 20:16:08 UTC
I actually tried to fix it since it seems to be pretty easy. But unfortunately I never contributed before.

I tried to compile plasma and the kcm, but I failed and ran out of time. Maybe I'll fix another bug soon :)

So it's probably best I leave this one to the pros.
Comment 6 Rajeesh K V 2017-07-04 16:41:45 UTC
Fixed by https://phabricator.kde.org/D6488