Bug 377075 - transition checkboxes do not save checked state
Summary: transition checkboxes do not save checked state
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Effects & Transitions (show other bugs)
Version: git-master
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: Vincent PINON
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-01 20:25 UTC by lukefromdc
Modified: 2017-08-07 04:10 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description lukefromdc 2017-03-01 20:25:14 UTC
checkboxes for "reverse" and "invert" in transitions do not work in current GIT master (anything recent, just confirmed with a 3-1-2017 pull). The default settings on first setting up a transition are "sane defaults" that work, but the checkboxes "remember" these defaults rather than applying and saving any changes.

In other words, if the "reverse transition" box is checked by default for a transition to a lower track, one would expect that unchecking it would make the transition run back to the upper (previous)track and that this state would be saved. Instead, the change is not applied, and if the transition is deselected and selected again on the timeline, the checkbox will be back in its original default state: checked if it was checked by default, unchecked if it was not checked by default. Any user changes will be gone.

Thus, it is not possible to do things like a "reverse clock" transition or use anything but the default settings until this is fixed. 

To duplicate this, build and install kdenlive from git master (now 17.03.70) and open kdenlive. Add two clips to the project and put them both on the timeline with an overlap. Create a transition. Now select that transition and try to edit the direction. The "wipe" transition will show two checkboxes, "dissolve" will show one. The settings are a sane default and usually OK. Check an unchecked checkbox or uncheck a checked on. Select anything else on the timeline, then select the same transition again. You will see that your change has not been saved.

Using kdenlive from GIT master over MLT 6.5.0 build from Nov 22, 2016. That's a bit old so will try a current build and report that result
Comment 1 lukefromdc 2017-03-01 21:09:37 UTC
All these tests are with movit enabled if that makes any difference.

MLT from current git master caused kdenlive to crash on adding transitions or resizing clips, presuming this a problem in MLT. Thus no retest with current MLT master possible right now. This was true with new build around MLT from 3-1-2017 pull, with either Nov 22 or current Movit.
Comment 2 lukefromdc 2017-03-07 20:54:11 UTC
On 3-7, some commit, probably this one:

https://cgit.kde.org/kdenlive.git/commit/?id=35af0b4af89a6b92c33217f191dc55fa4d5cbb4d

Partially fixed this. On the "dissolve" transition with its single checkbox for "reverse," the checkbox selection is now correctly saved and correctly applied.

On the "wipe" transition with two checkboxes however, the top checkbox for "invert" now works, but the bottom one for "revert" still returns to the default settiog.
Comment 3 lukefromdc 2017-03-13 03:49:08 UTC
Further testing with git master from 3-12-2017 showed the bottom checkbox on a "wipe" transition not having its checked state saved in the GUI, but being correctly applied at playback or render so long as it has been checked and unchecked (or unchecked and rechecked) at least once each. Top checkbox works as expected, bottom checkbox actually seems to save its state to the project but not be properly re-read by the GUI when the transition is selected a second time as or 3-12.2017.

This is touchy but actually usable with a bit of fiddling, though one error with a transition will cause me to re-render the project if it gets that far
Comment 4 lukefromdc 2017-04-07 04:25:52 UTC
I managed to bisect this,

9bb0e6100d1c5eae737cf4e39aa6cebfb05e4ad1 "Add base class to boolParam" 
came up as the first bad commit. Transitions worked normally on a build from previous commit
10abf7711ea600bd6be418b576c1044bbf0cc96d
Comment 5 lukefromdc 2017-04-07 05:30:01 UTC
9bb0e6100d1c5eae737cf4e39aa6cebfb05e4ad1

cannot be automatically reverted due to conflicts, this might be beyond my ability to fix myself
Comment 6 lukefromdc 2017-08-07 04:10:56 UTC
FIXED

Fixed by https://cgit.kde.org/kdenlive.git/commit/?id=cbb224784f1effd7d2b37afd7513de4f1dd634aa

checkboxes now display properly, I can finally update the version I use from 16.12 all the way back to current GIT master as I normally prefer to work with. Yes, I always keep older versions around to deal with new bugs