Bug 377055 - some icons cannot be pinned to panel on wayland
Summary: some icons cannot be pinned to panel on wayland
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Icons-only Task Manager (show other bugs)
Version: 5.9.3
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-01 10:44 UTC by miku84
Modified: 2017-07-11 07:05 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description miku84 2017-03-01 10:44:15 UTC 
some icons cannot be pinned to panel on wayland, using icons only manager. The right click pin is greyed out.

example for issue: Firefox, krita, clementine,krusader
working: dolpin, virtualbox, gwenview


Manjaro, KF 5.31, Plasma 5.9.3
Comment 1 Eike Hein 2017-03-01 17:30:04 UTC 
Those are probably XWayland apps without a proper Wayland appid.

I'd need access to their X11 WM_CLASS and then refactor the code to use the heuristic from XWindowTasksModel also on Wayland for XWayland windows. Wayland also needs the pid code still for the pid fallback in that heuristic.

Or we ignore XWayland and wait for apps to get ported.
Comment 2 miku84 2017-07-10 11:01:01 UTC 
I think it is a major thing to miss. I would not try to use wayland until these separate W icons are there, because it is confusing and has the "not finished" feeling...
Comment 3 Eike Hein 2017-07-11 05:42:09 UTC 
What I wrote above has been implemented on the master branch since then.
Comment 4 miku84 2017-07-11 06:49:43 UTC 
Thanks, that is great news! In which version will be released? Plasma 5.11?
I tried it on 5.10.3, but this feature was missing.
Comment 5 Eike Hein 2017-07-11 07:05:55 UTC 
Yep, 5.11.