Bug 376987 - On screen display included in window layout
Summary: On screen display included in window layout
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-desktop-grid (show other bugs)
Version: 5.9.2
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: KWin default assignee
URL: https://phabricator.kde.org/D6835
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-27 16:35 UTC by pbs3141
Modified: 2017-08-24 08:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.10.4
Sentry Crash Report:
mgraesslin: ReviewRequest+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description pbs3141 2017-02-27 16:35:50 UTC
Overview:

If you activate the desktop grid while the screen brightness indicator is visible, then the brightness indicator is treated as an ordinary window with respect to the grid window layout.

Steps to reproduce:

 - Open a few windows.
 - Change the screen brightness, causing the indicator to appear.
 - Quickly activate the desktop grid before the indicator disappears.

Actual and incorrect result:

Each desktop gets its own brightness indicator, and any other windows are pushed aside to make room for them, until the indicators fade out and disappear.

Expected result:

Subjective, but I think the screen brightness indicator would most naturally be shown over anything including the desktop grid.

Bonus:

Here are some closely-related problems, possibly part of the same bug.

 - The brightness indicator is hidden while present windows is active.
 - The brightness indicator is not shown if you change the brightness when the desktop grid is active.
Comment 1 Martin Flöser 2017-07-22 15:48:13 UTC
Patch at: https://phabricator.kde.org/D6835

It's a rather obvious thing - so obvious that I didn't even test it (which could bite me, but...)
Comment 2 Martin Flöser 2017-07-25 05:10:12 UTC
Git commit cf62ac8039a5821e52c6fc8e6a7d45a38f350dd2 by Martin Flöser.
Committed on 22/07/2017 at 15:47.
Pushed by graesslin into branch 'Plasma/5.10'.

[effects] Exclude OSD windows from desktop grid

Summary:
FIXED-IN: 5.10.4

Test Plan: Compiles

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D6835

M  +1    -1    effects/desktopgrid/desktopgrid.cpp

https://commits.kde.org/kwin/cf62ac8039a5821e52c6fc8e6a7d45a38f350dd2
Comment 3 Szymon Łągiewka 2017-08-24 07:20:33 UTC
What about notifications? For me in 5.10.5 notifications are still visible in desktop grid. I can move grab and move them around and so on.
Comment 4 Martin Flöser 2017-08-24 08:54:15 UTC
(In reply to Szymon Łągiewka from comment #3)
> What about notifications? For me in 5.10.5 notifications are still visible
> in desktop grid. I can move grab and move them around and so on.

This bug was about on screen notification and not about regular notifications. If notifications are a problem please report a dedicated bug report.