Bug 376905 - Define plugin for krunner doesn't show up definition
Summary: Define plugin for krunner doesn't show up definition
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: dictionary (show other bugs)
Version: 5.9.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 365256 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-02-25 06:59 UTC by Looserof7
Modified: 2019-08-07 07:02 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.4


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Looserof7 2017-02-25 06:59:33 UTC
I have selected this to be under general component as there was no component which is specific to this plugin.

When I search in krunner for definition of particular world, consider:
'define hello', then I would get it's result in krunner itself, which wasn't appropriate as it was almost impossible for me to see whole definition of any word,
I think some kind of pop-up would be better to display it's definition, and time taken to query definition is really long.

Kde version :5.9.2
Comment 1 SH 2017-06-07 10:24:28 UTC
I can confirm - the way it currently works is usually unusable. You get one line that has the first few words of a definition and that's useless.

There should be a tooltip that shows the full definition when hovering over that line.

(Optionally I'd also love to see something like a qt5 port/clone of XFCE's dictionary that opens when you click that line; the XFCE devs really got it right with that app)
Comment 2 2wxsy58236r3 2019-07-01 03:13:19 UTC
*** Bug 365256 has been marked as a duplicate of this bug. ***
Comment 3 Kai Uwe Broulik 2019-07-30 07:04:06 UTC
Git commit cda996dfb011d50bcc1dcc68add42bdf24f175fc by Kai Uwe Broulik.
Committed on 30/07/2019 at 07:03.
Pushed by broulik into branch 'Plasma/5.16'.

Remove colon (:) prefix when looking up dictionary word

The dictionary engine lets us specify a server and dictionary but we don't need any of that,
and the engine can deal with just a word (these days?).
More importantly, the key inserted into the m_lockers map is without a colon and since sourceRemoved is also called without it,
the wait condition is never met and we time out eventually.
The colon has been in there forever but from current dictionary engine code I don't see why it would be neccessary.

CHANGELOG: Fixed dictionary runner not finding any definitions
FIXED-IN: 5.16.4

Differential Revision: https://phabricator.kde.org/D22814

M  +1    -1    runners/dictionary/dictionarymatchengine.cpp

https://commits.kde.org/kdeplasma-addons/cda996dfb011d50bcc1dcc68add42bdf24f175fc
Comment 4 Kai Uwe Broulik 2019-07-30 07:04:34 UTC
Nevermind, this bug report is about the visual representation, not the fact that it didn't work at all. :)
Comment 5 Kai Uwe Broulik 2019-08-07 07:02:27 UTC
Git commit eac0dbd5f1c0f1ba54bd9c9682da096d9c78db2a by Kai Uwe Broulik.
Committed on 07/08/2019 at 06:53.
Pushed by broulik into branch 'Plasma/5.12'.

Remove colon (:) prefix when looking up dictionary word

The dictionary engine lets us specify a server and dictionary but we don't need any of that,
and the engine can deal with just a word (these days?).
More importantly, the key inserted into the m_lockers map is without a colon and since sourceRemoved is also called without it,
the wait condition is never met and we time out eventually.
The colon has been in there forever but from current dictionary engine code I don't see why it would be neccessary.

CHANGELOG: Fixed dictionary runner not finding any definitions
FIXED-IN: 5.16.4

Differential Revision: https://phabricator.kde.org/D22814

(cherry picked from commit cda996dfb011d50bcc1dcc68add42bdf24f175fc)

M  +1    -1    runners/dictionary/dictionarymatchengine.cpp

https://commits.kde.org/kdeplasma-addons/eac0dbd5f1c0f1ba54bd9c9682da096d9c78db2a