Bug 376887 - layer icon for "show in timeline"
Summary: layer icon for "show in timeline"
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: 3.1.2
Platform: Other All
: NOR wishlist
Target Milestone: ---
Assignee: Emmet O'Neill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-24 13:13 UTC by gordie.lachance+dev
Modified: 2020-06-17 02:58 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gordie.lachance+dev 2017-02-24 13:13:36 UTC
Hi, it would be great to have a layer icon for the "show in timeline" option; so you can visually see which are the layers enabled/disabled in the timeline.
Thanks !
Comment 1 Halla Rempt 2017-02-27 13:32:49 UTC
I guess we could do this, though the layerbox is already overcrowded and making the icon take place even if the document doesn't have animation would be bad; not doing that would be a bit complicated.
Comment 2 Bollebib 2017-03-17 13:22:21 UTC
you can see it tho by looking at the layers with a lightbulb



maybe the lightbulb will need a different placmentfor easier parsing
or maybe the color filter needs extra option like hiding all non-animation layers or vice versa?
Comment 3 Scott Petrovic 2019-06-15 15:42:03 UTC
I personally would not want this. A lot of artists that use krita have no desire to animate. This just adds extra UI clutter that a lot of people will have to ignore.

I think if we do anything...we need to think about the workflow for animators and how they do the "show on timeline" in general. A better option might be to have a toggle to make all layers show in the timeline.
Comment 4 Ahab Greybeard 2019-06-15 17:04:17 UTC
At the moment, the lightbulb icon is used to indicate that a layer is animated and it is not present if a layer is not animated. It is grey or black+lit to show if onion skins are off or on.
This does not intrude for someone who isn't doing animations.
It does not indicate whether the layer is shown in the Timeline or not.

If the lightbulb  icon in the layers docker could be altered to indicate that the layer was in the Timeline (or not), that would be useful. Maybe a cross placed over it to indicate that it's not in the Timeline?

The Timeline docker controls for adding a layer are quite good but removing a layer from the Timeline is clunky and the 'Remove layer' option does in fact delete the layer from the image. https://bugs.kde.org/show_bug.cgi?id=407416

With many animated layers, it's important that the user has full and detailed control over which layers are shown in the Timeline and that can be done at the moment (but with clunky layer removal controls).

As an extra issue, an animated transparency mask does not have a lightbulb icon. You can't have an animated transparency mask unless its parent layer is animated but you can have an animated transparency mask alone in the Timeline (with no lightbulb icon displayed).
I deal with this by giving them a name "Animask 'parent name'" so I know what's happening.
Comment 5 Emmet O'Neill 2020-05-15 23:34:16 UTC
Git commit b382c780fa7707b45a2406e39714c9714ca65886 by Emmet O'Neill.
Committed on 15/05/2020 at 23:07.
Pushed by emmetoneill into branch 'emmetpdx/T12769/aninext'.

Added pushpin icon for pinned layers.

Now artists can easily see which of the layers on their timeline are
pinned and which are not.

M  +9    -0    libs/global/kis_global.h
M  +2    -2    plugins/dockers/animation/timeline_frames_model.cpp
M  +1    -1    plugins/dockers/animation/timeline_frames_model.h
M  +73   -32   plugins/dockers/animation/timeline_layers_header.cpp
M  +7    -2    plugins/dockers/animation/timeline_layers_header.h

https://invent.kde.org/kde/krita/commit/b382c780fa7707b45a2406e39714c9714ca65886
Comment 6 Emmet O'Neill 2020-06-17 02:58:39 UTC
Git commit ed035fe1fec634dd6a750d0b6dc934c6cadedee2 by Emmet O'Neill.
Committed on 17/06/2020 at 02:38.
Pushed by emmetoneill into branch 'master'.

Added pushpin icon for pinned layers.

Now artists can easily see which of the layers on their timeline are
pinned and which are not.

M  +9    -0    libs/global/kis_global.h
M  +2    -2    plugins/dockers/animation/timeline_frames_model.cpp
M  +1    -1    plugins/dockers/animation/timeline_frames_model.h
M  +73   -32   plugins/dockers/animation/timeline_layers_header.cpp
M  +7    -2    plugins/dockers/animation/timeline_layers_header.h

https://invent.kde.org/graphics/krita/commit/ed035fe1fec634dd6a750d0b6dc934c6cadedee2