Bug 376885 - The setting 'Always show original images' cannot be disabled in 5.5.0
Summary: The setting 'Always show original images' cannot be disabled in 5.5.0
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Setup-ImageEditor (show other bugs)
Version: 5.5.0
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-24 12:43 UTC by g0rak
Modified: 2022-02-02 05:07 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.5.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description g0rak 2017-02-24 12:43:12 UTC
I was testing Digikam 5.4.0 and the setting 'Preferences > Versioning > Always show original images' worked correctly.  I could disable it and it would hide old versions of images.

After upgrading to 5.5.0 (a pre-version bundle to get around Unique ID bug 375483 for Samsung phones) I noticed that I can no longer disable the 'Always show original images' setting.  It always stays enabled, even though other controls in preferences are able to be saved.

I've tried 2 releases of 5.5.0, one on 05/02/17 and one on 24/02/17 (today), both have this bug.

Downgrading to 5.4.0 makes this work again, but of course bug 375483 is back.  Thanks.
Comment 1 Maik Qualmann 2017-02-24 17:46:08 UTC
This problem is actually fixed on 22/01/17. With this commit:

https://commits.kde.org/digikam/e207361216234f742a57abc311d08d71a0c3acb8

I'll check it again.

Maik
Comment 2 Maik Qualmann 2017-02-24 18:13:10 UTC
Git commit 1546044e48ede7c7649d216fe7e07d3d55c832bd by Maik Qualmann.
Committed on 24/02/2017 at 18:12.
Pushed by mqualmann into branch 'master'.

fix again show original images
FIXED-IN: 5.5.0

M  +2    -2    NEWS
M  +1    -1    utilities/setup/editor/setupversioning.cpp

https://commits.kde.org/digikam/1546044e48ede7c7649d216fe7e07d3d55c832bd
Comment 3 g0rak 2017-02-24 22:30:26 UTC
Great, thanks.  I'll wait for the pre-version bundle to be updated and try it.