Bug 376854 - patchreview/purpose integration: result dialog doesn't provide review URL
Summary: patchreview/purpose integration: result dialog doesn't provide review URL
Status: RESOLVED WORKSFORME
Alias: None
Product: kdevplatform
Classification: Developer tools
Component: patchreview (show other bugs)
Version: git master
Platform: Compiled Sources macOS
: NOR normal
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-23 18:39 UTC by RJVB
Modified: 2022-11-30 05:16 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description RJVB 2017-02-23 18:39:58 UTC
I think that ever since I moved to KDevelop5 the upload-to-ReviewBoard feature has been flaky on Mac: about two times out of three the confirmation dialog fails to show the review URL. I also do not recall ever seeing an error dialog.

This also happens with my prototype Phabricator plugin for Purpose, so I dumped the json object that is retrieved in the patchreview plugin (the lambda function that acts as the slot receiving the `finished` signal from the Purpose plugin):

`auto PatchReviewToolView::showEditDialog()::(anonymous class)::operator()(const QJsonObject &, int, const QString &) const Purpose finished with output QJsonObject({"uninitialized":"true"})`

I have no idea what to do with this information other than reporting it.
Comment 1 RJVB 2017-02-23 19:14:33 UTC
The signal in question is Purpose::Menu::finished

where is that one emitted? I suppose that should be done by `Purpose::Menu`, but I cannot find where in the Purpose code...
Comment 2 Justin Zobel 2022-10-31 04:31:46 UTC
Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 3 Bug Janitor Service 2022-11-15 05:15:30 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Bug Janitor Service 2022-11-30 05:16:59 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!