Bug 376712 - Formats module is asking the user to relogin after pressing the Apply button
Summary: Formats module is asking the user to relogin after pressing the Apply button
Status: RESOLVED UPSTREAM
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_formats (other bugs)
Version First Reported In: 5.9.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Sebastian Kügler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-20 13:42 UTC by Jan Ziak (http://atom-symbol.net)
Modified: 2017-02-24 10:34 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Screenshot (17.97 KB, image/png)
2017-02-20 13:42 UTC, Jan Ziak (http://atom-symbol.net) 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Ziak (http://atom-symbol.net) 2017-02-20 13:42:47 UTC 
Created attachment 104126 [details]
Screenshot

Formats module asks the user to relogin after pressing the Apply button.
Comment 1 Sebastian Kügler 2017-02-20 15:27:57 UTC 
That is intended behavior, but thanks for the report.
Comment 2 Jan Ziak (http://atom-symbol.net) 2017-02-20 15:58:27 UTC 
(In reply to Sebastian Kügler from comment #1)
> That is intended behavior, but thanks for the report.

Do you mean you agree with storing locale information in immutable LC_* environment variables?
Comment 3 Sebastian Kügler 2017-02-24 09:59:31 UTC 
I wrote the code, so yes.
Comment 4 Jan Ziak (http://atom-symbol.net) 2017-02-24 10:34:57 UTC 
(In reply to Sebastian Kügler from comment #3)
> I wrote the code, so yes.

Just because some decades ago somebody temporarily solved a problem at hand by storing locale information in environment variables doesn't necessarily imply that it is the right thing to do from a long-term perspective.

I can change the behavior of the getenv() function to anything I like on my machines - the standard immutability of LC_* variables is an issue I can overcome if necessary.